Skip to content

Remove extras from to_tap_class annotations & add them for pydantic models#174

Merged
martinjm97 merged 3 commits intoswansonk14:mainfrom
Daraan:tapify-remove-extra-annotations
Dec 30, 2025
Merged

Remove extras from to_tap_class annotations & add them for pydantic models#174
martinjm97 merged 3 commits intoswansonk14:mainfrom
Daraan:tapify-remove-extra-annotations

Conversation

@Daraan
Copy link
Contributor

@Daraan Daraan commented Dec 28, 2025

Separate cleaned annotations and annotations with extras to be equivalent to the Tap class interface.

Resolves: #173

Lets see if anything goes wrong with the tests

@codecov-commenter
Copy link

codecov-commenter commented Dec 28, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.91%. Comparing base (88d12c8) to head (0cfc22e).

Files with missing lines Patch % Lines
src/tap/tapify.py 80.00% 3 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #174      +/-   ##
==========================================
- Coverage   94.22%   93.91%   -0.32%     
==========================================
  Files           4        4              
  Lines         745      756      +11     
==========================================
+ Hits          702      710       +8     
- Misses         43       46       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Daraan
Copy link
Contributor Author

Daraan commented Dec 29, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review. ✅ Project coverage is 93.91%. Comparing base (88d12c8) to head (0cfc22e).
Files with missing lines Patch % Lines
src/tap/tapify.py 80.00% 3 Missing ⚠️

Coverage for the missing lines will come from #176 / #175, which however need this PR first.
I think this line cannot be covered, as pydantic will clean Annotated and therefore will never have an Annotated object here for now to enter the else path.

  else:
        annotation.__metadata__ = (*annotation.__metadata__, *arg_data.pydantic_metadata)

@Daraan Daraan changed the title Remove extras from to_tap_class annotations Remove extras from to_tap_class annotations & add them for pydantic models Dec 29, 2025
@martinjm97 martinjm97 merged commit ac813d3 into swansonk14:main Dec 30, 2025
15 of 17 checks passed
@Daraan Daraan deleted the tapify-remove-extra-annotations branch December 30, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tapify annotations do not clean extras

3 participants

Comments