Skip to content

TapIgnore for to_tap_class / tapify#175

Merged
martinjm97 merged 6 commits intoswansonk14:mainfrom
Daraan:ignore-tapify
Dec 30, 2025
Merged

TapIgnore for to_tap_class / tapify#175
martinjm97 merged 6 commits intoswansonk14:mainfrom
Daraan:ignore-tapify

Conversation

@Daraan
Copy link
Contributor

@Daraan Daraan commented Dec 28, 2025

Resolves: #172

To also work for pydantic needs: #174, thats why test fail after the last commit.

Daraan and others added 4 commits December 28, 2025 11:03
Co-authored-by: Jesse Michel <8813660+martinjm97@users.noreply.github.com>
@codecov-commenter
Copy link

codecov-commenter commented Dec 28, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.27%. Comparing base (88d12c8) to head (71b9215).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #175      +/-   ##
==========================================
+ Coverage   94.22%   94.27%   +0.04%     
==========================================
  Files           4        4              
  Lines         745      751       +6     
==========================================
+ Hits          702      708       +6     
  Misses         43       43              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@martinjm97 martinjm97 merged commit 7546d95 into swansonk14:main Dec 30, 2025
0 of 15 checks passed
@martinjm97
Copy link
Collaborator

Hi @Daraan,

Thank you for the timely PRs! We were just about to try to implement this when we saw you already did it! Thank you!

--JK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make TapIgnore work for tapify

3 participants

Comments