Open
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #176 +/- ##
==========================================
+ Coverage 94.18% 94.38% +0.20%
==========================================
Files 4 4
Lines 757 784 +27
==========================================
+ Hits 713 740 +27
Misses 44 44 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Daraan
commented
Dec 29, 2025
Comment on lines
-186
to
188
| kwargs["help"] += " " + self.class_variables[variable]["comment"] | ||
| if variable in self.class_variables and (comment := self.class_variables[variable]["comment"]): | ||
| kwargs["help"] += " " + comment | ||
|
|
Contributor
Author
There was a problem hiding this comment.
This avoids just an additional untrimmed space at the end of the help message if there is none; i.e. "(int, required) " -> "(int, required)"
Refactor tests to use updated function signatures and handle optional parameters correctly.
Contributor
Author
|
Ready for review :) |
Collaborator
|
Thank you! This looks great! Sorry for the delay, we'll do our best to review this sizable PR soon. --JK |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #169
To also work for pydantic needs: #174, then also resolves: #165 (thats why latest tests) fail
Supports