Fix remote_directory to check directory instead of file#430
Closed
neidiom wants to merge 1 commit intoitamae-kitchen:masterfrom
Closed
Fix remote_directory to check directory instead of file#430neidiom wants to merge 1 commit intoitamae-kitchen:masterfrom
neidiom wants to merge 1 commit intoitamae-kitchen:masterfrom
Conversation
check_file_is_file always returned false for directories, causing updated! to fire on every run and breaking idempotency. Also added -r flag to diff for recursive directory comparison.
Member
|
@neidiom You opening too many pull requests in short period and the changes looks a trivial change intended solely for merging purpose to me. I appreciate contributions, but I'd ask you to pause and consider: does this change meaningfully benefit users or the codebase? |
This was referenced Mar 4, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check_file_is_file always returned false for directories, causing updated! to fire on every run and breaking idempotency. Also added -r flag to diff for recursive directory comparison.