Add test for tmpdir permissions#393
Open
neidiom wants to merge 2 commits intoitamae-kitchen:masterfrom
Open
Conversation
Add a spec to ensure tmpdir is not world-writable.
Contributor
Author
|
@unasuke please review. |
Member
|
@neidiom Fix failed integration tests please 😌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a spec to ensure tmpdir is not world-writable.
Problem: The temporary directory used during recipe execution is set to world-readable, world-writable, and world-executable (
777). Any user on the system can list directory contents, read temp file names, create decoy files, or delete files in progress. While individual temp files are set to0600, the directory permissions still allow enumeration and symlink attacks. This is especially concerning because Itamae typically runs as root.