Improve default ground plane rendering - #7609
Draft
maxkra15 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This draft makes the proposed ground-plane appearance self-contained so it can be reviewed without changing the shared Nucleus asset:
GroundPlaneCfg.sizechanges;No Nucleus or public S3 asset was modified.
Review assets
Newton limitation and proposed follow-up
Newton 1.5.1 imports one albedo texture and scalar material values, but its USD viewer drops the per-instance roughness/metallic array for textured meshes. The 49-line Isaac Lab compatibility override preserves uniform values for the pinned release. Newton main now contains generalized scalar material handling, so this override can be removed after the dependency update.
Newton still does not import a connected roughness map: its USD importer explicitly falls back to a scalar, and its Mesh representation exposes one color texture plus scalar roughness. Consequently, the preview USD represents glossy checks as a second visual-only mesh 0.1 mm above the rough base.
That geometry workaround is intentionally presented for review rather than as the desired final architecture. It adds 5,000 quads/10,000 triangles, and resizing the 100 m plane also scales those authored checker cells. The clean final solution is a single UV-scaled quad once Newton supports roughness textures end to end.
Asset publication proposal
If the appearance is accepted, upload it first under an isolated, versioned path such as:
Isaac/IsaacLab/Environments/Grid/default_ground_plane_checker_v1/default_ground_plane.usdaKeeping the USD and its
Materials/Texturesdirectory together avoids modifying the existingdefault_ground_plane.usdaor its texture files. The PR can then switch from the bundled review fixture to that path before merge; the normal Isaac-dev-to-public-S3 sync can publish it without an in-place asset mutation.Type of change
Release backport
developScreenshots
The robot reflection is visible on the dark checks while the off-white checks remain rough.
Validation
uv run --frozen python -m pytest source/isaaclab/test/sim/test_default_ground_plane.py -q— 3 passeduv run --frozen python -m pytest source/isaaclab/test/sim/test_spawn_from_files.py -k test_spawn_ground_plane -q— 1 passeduv run --frozen python -m pytest source/isaaclab/test/terrains/test_terrain_importer.py -k test_plane -q— 4 passeduv run --frozen python -m pytest source/isaaclab_visualizers/test/test_newton_adapter.py -q— 56 passeduv run --frozen isaaclab -f— passeduv build source/isaaclab --wheel— passed; all three ground-plane assets are present in the wheelChecklist
CONTRIBUTORS.md