Remove solver-specific velocity task tuning - #7607
Conversation
Greptile SummaryThis PR removes solver-specific tuning from rough-velocity configurations so backend selection no longer changes task or training configuration inputs.
Confidence Score: 5/5The PR appears safe to merge; no actionable correctness, security, or repository-rule violations were identified. The simplified base-COM event remains intact during preset resolution, the Newton alias selects the expected MJWarp solver configuration, and the removed tuning values have no remaining internal callers that depend on their preset shape. Important Files Changed
Reviews (1): Last reviewed commit: "Remove solver-specific velocity task tun..." | Re-trigger Greptile |
There was a problem hiding this comment.
Isaac Lab Review Bot
The backend-tuning cleanup is coherent, but flattening EventsCfg.base_com changes an existing configuration access path and needs explicit breaking-change classification and migration guidance before merge.
- Design and architecture: Removing solver-conditioned armatures and training budgets simplifies backend comparisons. However, replacing the one-option
PresetCfgwith anEventTermchanges the structure inherited by downstream velocity configurations frombase_com.defaulttobase_com. - API: The
EventsCfg.base_comtype change breaks downstream configurations using the previously shippedself.events.base_com.default.params[...]customization pattern. The changelog should mark this compatibility change clearly and document thebase_com.defaulttobase_commigration. - Implementation: The in-repository a1, go1, and digit callers were updated consistently, and the legacy Newton alias test now checks the selected
MJWarpSolverCfgdirectly. These internal updates also demonstrate the concrete migration downstream callers must perform.
Minor fixes needed. Posted 1 actionable finding inline.
Automated review; human maintainers own approval decisions.
| "com_range": {"x": (-0.05, 0.05), "y": (-0.05, 0.05), "z": (-0.01, 0.01)}, | ||
| }, | ||
| ), | ||
| base_com = EventTerm( |
There was a problem hiding this comment.
🟡 Warning · Api — base_com type change lacks migration guidance
EventsCfg.base_com changes from a PresetCfg to a plain EventTerm, so any config following the pattern this repo shipped — self.events.base_com.default.params[...], as a1, go1 and digit did before this diff — now raises AttributeError during __post_init__. The changelog fragment describes it only as "a plain event" and gives migration guidance for the removed backend values, not for this access path. Mark it breaking and state the base_com.default -> base_com migration.
|
|
||
| # scene | ||
| self.scene.robot = ANYMAL_C_CFG.replace(prim_path="{ENV_REGEX_NS}/Robot") | ||
| self.scene.robot.actuators["legs"].armature = preset( |
There was a problem hiding this comment.
Does it not need armature anymore and no Nan?
There was a problem hiding this comment.
yup no nan anymore
|
run-ci |
Description
Remove backend-specific task and training changes from rough velocity configurations so physics selection no longer silently changes the comparison inputs.
Downstream configurations that intentionally require different values can still set them explicitly.
Type of change
Release backport
Testing
uv run --extra test python -m pytest source/isaaclab_tasks/test/core/test_hydra.py source/isaaclab_tasks/test/core/test_velocity_newton_cfg.py— 88 passed.uv run isaaclab -f— passed.Checklist