Add parameter to ExtModule for requirements #5174
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trmckay
commented
Jan 23, 2026
trmckay
force-pushed
the
extmodule-require
branch
from
0560b6a to
32c502a
Compare
trmckay
force-pushed
the
extmodule-require
branch
from
7103df8 to
919dd04
Compare
trmckay
force-pushed
the
extmodule-require
branch
from
2359f0a to
85a7ae7
Compare
jackkoenig
reviewed
Jan 24, 2026
Comment on lines
53
to
57
| abstract class BlackBox( | ||
| val params: Map[String, Param] = Map.empty[String, Param], | ||
| override protected final val knownLayers: Seq[Layer] = Seq.empty[Layer] | ||
| val params: Map[String, Param] = Map.empty[String, Param], | ||
| override protected final val knownLayers: Seq[Layer] = Seq.empty[Layer], | ||
| override protected final val requirements: Seq[String] = Seq.empty[String] | ||
| ) extends BaseBlackBox { |
Contributor
There was a problem hiding this comment.
Blackbox is deprecated and we will remove it right before Chisel 8 release so I wouldn't bother.
jackkoenig
reviewed
Jan 24, 2026
Comment on lines
+32
to
+35
| case x @ DefBlackBox(id, _, _, _, _, _, _) => !id._isImportedDefinition | ||
| case DefIntrinsicModule(_, _, _, _, _) => false | ||
| case DefClass(_, _, _, _) => false | ||
| case x => true |
Contributor
There was a problem hiding this comment.
I'd just simplify this
Suggested change
| case x @ DefBlackBox(id, _, _, _, _, _, _) => !id._isImportedDefinition | |
| case DefIntrinsicModule(_, _, _, _, _) => false | |
| case DefClass(_, _, _, _) => false | |
| case x => true | |
| case d: DefBlackBox => !d.id._isImportedDefinition | |
| case _: DefIntrinsicModule => false | |
| case _: DefClass => false | |
| case _ => true |
jackkoenig
reviewed
Jan 24, 2026
Contributor
jackkoenig
left a comment
jackkoenig
left a comment
There was a problem hiding this comment.
Generally LGTM, I think we should wait until a firtool release with requires support (and bump) before merging. I want to do a Chisel release soon and might do so before firtool supports this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an API for the
requireskeyword supported by CIRCT after llvm/circt#9496.Contributor Checklist
docs/src?Type of Improvement
Desired Merge Strategy
Release Notes
requirementsparameter toExtModulefor tracking external build requirements.Reviewer Checklist (only modified by reviewer)
3.6.x,5.x, or6.xdepending on impact, API modification or big change:7.0)?Enable auto-merge (squash)and clean up the commit message.Create a merge commit.