Package overhaul after running ruff and adding pytest tests #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 20, 2025
Contributor
|
Note that this PR requires correlated changes across repos since the actual package has been renamed from |
jcfreeman2
approved these changes
Oct 20, 2025
Contributor
jcfreeman2
left a comment
jcfreeman2
left a comment
There was a problem hiding this comment.
I've created a build using this PR as well has its associated PRs, CS2FD_DEV_251020_A9 (https://github.com/DUNE-DAQ/daq-release/actions/runs/18659788637) and integration tests all ran successfully (https://github.com/DUNE-DAQ/daq-release/actions/runs/18661336383). Furthermore, the 8 pytests Gordon added to connectivityserver all pass with an impressive 87% coverage of connectionflask.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code updated to address issues raised by ruff.
Rename files and directories without hyphens in order to add pytest tests. Then added some extra input validation in server to handle some problems found by the pytests.
Bumped version to 1.3.0 and updated docs. Will need tagging with 1.3.0 after merge.
NB: Changing the internal package name and source file name means that anything starting the server locally without using the docker image will need updating. This affects packages