Skip to content

Remove references to the connectivity service from the test OKS confi…#354

Merged
gcrone merged 1 commit intodevelopfrom
gcrone/pytest
Oct 21, 2025
Merged

Remove references to the connectivity service from the test OKS confi…#354
gcrone merged 1 commit intodevelopfrom
gcrone/pytest

Conversation

@gcrone
Copy link
Copy Markdown
Contributor

@gcrone gcrone commented Oct 20, 2025

…g since the unit tests don't need it.

The connectivityserver has been renamed so the gunicorn startup line in the configuration is no longer valid. As far as I can see the connectivityserver is not actually used by the unit tests that use the config file anyway.

@gcrone gcrone requested a review from eflumerf October 20, 2025 15:48
@jcfreeman2 jcfreeman2 self-requested a review October 20, 2025 21:11
@jcfreeman2
Copy link
Copy Markdown
Contributor

I'm fine with this.

I've created a build using this PR as well as its associated PRs, CS2FD_DEV_251020_A9 (https://github.com/DUNE-DAQ/daq-release/actions/runs/18659788637) and integration tests all ran successfully (https://github.com/DUNE-DAQ/daq-release/actions/runs/18661336383).

For further context, please see DUNE-DAQ/daq-deliverables#198 and DUNE-DAQ/connectivityserver#24

Copy link
Copy Markdown
Member

@eflumerf eflumerf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit tests still work fine

@gcrone gcrone marked this pull request as ready for review October 21, 2025 15:25
@gcrone gcrone merged commit a2b8084 into develop Oct 21, 2025
4 checks passed
@gcrone gcrone deleted the gcrone/pytest branch October 21, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants