fix: bake batch-array-entrypoint.sh into the image - #470
Merged
Conversation
…h-entrypoint.sh The AWS Batch Array job definition (sms-cdk RayArrayJobDef) runs this image's command as /opt/batch-array-entrypoint.sh, but only sms-cdk's own standalone docker/ray.Dockerfile baked the script in -- the real per-commit workload image (what _ensure_array_job_def actually swaps the job definition's image to) never got it. Every array dispatch failed identically: CannotStartContainerError: stat /opt/batch-array-entrypoint.sh: no such file or directory. Fix mirrors the existing ray-batch-entrypoint.sh convention exactly: a local docker/ copy (synced from sms-cdk/scripts/batch-array-entrypoint.sh, same as ray-batch-entrypoint.sh already is) + one COPY + chmod line. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
eagmon
approved these changes
Aug 7, 2026
eagmon
left a comment
eagmon
left a comment
Member
There was a problem hiding this comment.
Bake batch-array-entrypoint.sh into the image. Additive, green CI. LGTM (pairs with sms-ecoli#37).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_submit_arraypath) fails on every commit: the job definition runs/opt/batch-array-entrypoint.sh, but that script was only ever baked into sms-cdk's own standalone Ray image, never into this repo's own per-commit workload image (the one_ensure_array_job_defactually swaps the job definition's image to).CannotStartContainerError: stat /opt/batch-array-entrypoint.sh: no such file or directory.ray-batch-entrypoint.shconvention exactly (this repo already hand-syncs that script from sms-cdk intodocker/) — same treatment for its new sibling.Test plan
docker/batch-array-entrypoint.shadded, synced verbatim fromsms-cdk/scripts/batch-array-entrypoint.shDockerfileCOPY + chmod line added, identical pattern to the existingray-batch-entrypoint.shlines directly above it🤖 Generated with Claude Code