Skip to content

SCAL-291789 Remove default navigation, home page and list page version settings #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ts-mohammedashad wants to merge 2 commits into
base: main
Choose a base branch
from
Open

SCAL-291789 Remove default navigation, home page and list page version settings #413

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
106879a
SCAL-291789 Remove listpageVersion parameter from embed app URL
ts-mohammedashad Jan 22, 2026
645f43a
SCAL-291789Remove unnecessary whitespace
ts-mohammedashad Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/embed/app.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1012,7 +1012,7 @@ describe('App embed tests', () => {
await executeAfterWait(() => {
expectUrlMatchesWithParams(
getIFrameSrc(),
`http://${thoughtSpotHost}/?embedApp=true&primaryNavHidden=true&profileAndHelpInNavBarHidden=false&modularHomeExperience=false&navigationVersion=v2&listpageVersion=v2${defaultParams}${defaultParamsPost}#/home`,
`http://${thoughtSpotHost}/?embedApp=true&primaryNavHidden=true&profileAndHelpInNavBarHidden=false&modularHomeExperience=false&navigationVersion=v2${defaultParams}${defaultParamsPost}#/home`,
);
});
});
Expand All @@ -1030,7 +1030,7 @@ describe('App embed tests', () => {
await executeAfterWait(() => {
expectUrlMatchesWithParams(
getIFrameSrc(),
`http://${thoughtSpotHost}/?embedApp=true&primaryNavHidden=true&profileAndHelpInNavBarHidden=false&modularHomeExperience=true&navigationVersion=v3&listpageVersion=v2${defaultParams}${defaultParamsPost}#/home`,
`http://${thoughtSpotHost}/?embedApp=true&primaryNavHidden=true&profileAndHelpInNavBarHidden=false&modularHomeExperience=true&navigationVersion=v3${defaultParams}${defaultParamsPost}#/home`,
);
});
});
Expand Down
3 changes: 0 additions & 3 deletions src/embed/app.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -904,9 +904,6 @@ export class AppEmbed extends V1Embed {
// Set homePageVersion to v2 by default to reset the LD flag value
// for the homepageVersion.
params[Param.HomepageVersion] = 'v2';
// Set listpageVersion to v2 by default to reset the LD flag value
// for the listpageVersion.
params[Param.ListPageVersion] = ListPage.List;
if (discoveryExperience) {
// primaryNavbarVersion v3 will enabled the new left navigation
if (discoveryExperience.primaryNavbarVersion === PrimaryNavbarVersion.Sliding) {
Expand Down
Loading