SCAL-291789 Remove default navigation, home page and list page version settings

[ts-mohammedashad]

No description provided.

[mnk-blr]

✅ Snyk checks have passed. No issues have been found so far.

Status	Scanner	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues
✅	Licenses	0	0	0	0	0 issues
✅	Code Security	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

[gemini-code-assist]

Summary of Changes

Hello @ts-mohammedashad, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the application's embedding logic by removing hardcoded default version settings for navigation, homepage, and list pages. By eliminating these explicit 'v2' assignments, the system can now rely on more dynamic configuration mechanisms, such as discoveryExperience settings, to determine the appropriate versions, thereby enhancing flexibility and reducing potential conflicts with cluster-level configurations.

Highlights

• Removal of Hardcoded Defaults: The pull request removes explicit default settings for navigation, homepage, and list page versions (all set to 'v2') within the AppEmbed class.
• Dynamic Versioning: This change allows these version settings to be determined by other configurations, such as discoveryExperience settings or feature flags, rather than being hardcoded.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request removes explicit default settings for navigation, homepage, and listpage versions. This change introduces a discrepancy with existing unit tests that still assert the presence of these 'v2' version parameters in the generated URL. It's critical to either update the tests to reflect the new expected behavior (if 'v2' is no longer the default) or reintroduce the explicit settings if 'v2' remains the intended default.

I am having trouble creating individual review comments. Click here to see my feedback.

src/embed/app.ts (898-909)

The lines setting Param.NavigationVersion, Param.HomepageVersion, and Param.ListPageVersion to 'v2' by default have been removed. However, the corresponding unit tests in src/embed/app.spec.ts (e.g., lines 944, 967, 1014, 1032) still expect these parameters to be present in the generated URL with a 'v2' value when discoveryExperience does not explicitly override them. This creates a discrepancy between the code and the tests. Please clarify if these parameters are now implicitly defaulting to 'v2' or if the tests need to be updated to reflect their absence. If 'v2' is still the intended default, the original comments about "avoid problems" and "resetting LD flag values" should be considered.

[pkg-pr-new]

Open in StackBlitz

npm i https://pkg.pr.new/thoughtspot/visual-embed-sdk/@thoughtspot/visual-embed-sdk@413

commit: 645f43a

[sonar-prod-ts]

SonarQube Quality Gate

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
50.0% Duplication