Skip to content

Add colon (:) to invalid char for revision name add unittest #1741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kimwoo123 wants to merge 3 commits into from
Closed

Add colon (:) to invalid char for revision name add unittest #1741

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
21603f1
Add colon (:) to invalid char for revision name
PatilHrushikesh Sep 22, 2024
725e879
Merge branch 'main' of https://github.com/sqlalchemy/alembic into Pat…
kimwoo123 Oct 28, 2025
3894b1f
fix: disallow ':' in custom revision IDS (#1541)
kimwoo123 Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion alembic/script/revision.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
_TR = TypeVar("_TR", bound=Optional[_RevisionOrStr])

_relative_destination = re.compile(r"(?:(.+?)@)?(\w+)?((?:\+|-)\d+)")
_revision_illegal_chars = ["@", "-", "+"]
_revision_illegal_chars = ["@", "-", "+", ":"]


class _CollectRevisionsProtocol(Protocol):
Expand Down
7 changes: 7 additions & 0 deletions docs/build/unreleased/1540.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
.. change::
:tags: usecase, revision
:tickets: 1540

Disallow ':' character in custom revision identifiers. Previously, using a colon in
a revision ID (e.g., 'REV:1') caused alembic to interpret it as a revision range,
resulting in upgrade failures.
10 changes: 10 additions & 0 deletions tests/test_script_production.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,6 +393,16 @@ def test_illegal_revision_chars(self):
rev_id="no@atsigns",
)

assert_raises_message(
util.CommandError,
r"Character\(s\) ':' not allowed in "
"revision identifier 'no:colons'",
command.revision,
self.cfg,
message="some message",
rev_id="no:colons",
)

assert_raises_message(
util.CommandError,
r"Character\(s\) '-, @' not allowed in revision "
Expand Down