Add colon (:) to invalid char for revision name add unittest

[kimwoo123]

Description

Apologies for the sudden push, adding commit to move PR forward
Not sure if adding a commit to this old PR is appropriate,
but if you have time, I would appreciate your review.
Hoping this old PR gets applied, closed, or resolved in some way.

Refer to: #1540, #1541

Checklist

This pull request is:

• A documentation / typographical error fix
  • Good to go, no issue or tests are needed
• A short code fix
  • please include the issue number, and create an issue if none exists, which
    must include a complete example of the issue. one line code fixes without an
    issue and demonstration will not be accepted.
  • Please include: Fixes: #<issue number> in the commit message
  • please include tests. one line code fixes without tests will not be accepted.
• A new feature implementation
  • please include the issue number, and create an issue if none exists, which must
    include a complete example of how the feature would look.
  • Please include: Fixes: #<issue number> in the commit message
  • please include tests.

Have a nice day!

[zzzeek]

sure!

IIUC, this is only an error raise for an invalid revision name that breaks later on anyway, this is blocking something somehow ?

[sqla-tester]

OK, this is sqla-tester setting up my work on behalf of zzzeek to try to get revision 3894b1f of this pull request into gerrit so we can run tests and reviews and stuff

[sqla-tester]

New Gerrit review created for change 3894b1f: https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/6266

[kimwoo123]

Thank you for taking a look.

IIUC, this is only an error raise for an invalid revision name that breaks later on anyway, this is blocking something somehow ?

This isn’t fixing a major issue — it’s mainly to improve consistency in error handling.

[sqla-tester]

Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/6266 has been merged. Congratulations! :)