Skip to content

add Vue service to DNS load balancer config #1425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
serglom21 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add Vue service to DNS load balancer config #1425

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions _dns/config.yaml.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,9 @@ services:
- host: "${SPRINGBOOTOTLP_SUBDOMAIN}.${DOMAIN}"
gae_service: ${SPRINGBOOTOTLP_APP_ENGINE_SERVICE}

- host: "${VUE_SUBDOMAIN}.${DOMAIN}"
gae_service: ${VUE_APP_ENGINE_SERVICE}
Comment on lines +52 to +53
Copy link
Copy Markdown
Contributor

@sentry sentry bot Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The DNS configuration template references the variable VUE_SUBDOMAIN, which is not defined in any environment files, causing the deployment script to fail.
Severity: CRITICAL

Suggested Fix

Define the VUE_SUBDOMAIN variable in the relevant environment configuration files, such as production.env and staging.env. Follow the existing pattern for other services, for example, by adding VUE_SUBDOMAIN=vue to production.env and VUE_SUBDOMAIN=staging-vue to staging.env.

Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: _dns/config.yaml.template#L52-L53

Potential issue: The new DNS configuration in `_dns/config.yaml.template` references the
variable `${VUE_SUBDOMAIN}`. However, this variable is not defined in any environment
configuration files (e.g., `production.env`, `staging.env`). The deployment script
utilizes `envsubst.sh` with a strict mode (`--strict-allow-empty`) that explicitly fails
when a variable is undefined. As a result, attempting to deploy the `_dns` project will
cause the deployment script to terminate with an error, preventing the entire DNS load
balancer configuration from being applied. This affects all services that rely on this
DNS configuration, not just the new Vue service.

Did we get this right? 👍 / 👎 to inform future reviews.


# Cloud Run services
- host: "${AGENT_SUBDOMAIN}.${DOMAIN}"
gcr_service: ${AGENT_CLOUD_RUN_SERVICE}
Expand Down
Loading