add Vue service to DNS load balancer config#1425
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
|
| - host: "${VUE_SUBDOMAIN}.${DOMAIN}" | ||
| gae_service: ${VUE_APP_ENGINE_SERVICE} |
There was a problem hiding this comment.
Bug: The DNS configuration template references the variable VUE_SUBDOMAIN, which is not defined in any environment files, causing the deployment script to fail.
Severity: CRITICAL
Suggested Fix
Define the VUE_SUBDOMAIN variable in the relevant environment configuration files, such as production.env and staging.env. Follow the existing pattern for other services, for example, by adding VUE_SUBDOMAIN=vue to production.env and VUE_SUBDOMAIN=staging-vue to staging.env.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: _dns/config.yaml.template#L52-L53
Potential issue: The new DNS configuration in `_dns/config.yaml.template` references the
variable `${VUE_SUBDOMAIN}`. However, this variable is not defined in any environment
configuration files (e.g., `production.env`, `staging.env`). The deployment script
utilizes `envsubst.sh` with a strict mode (`--strict-allow-empty`) that explicitly fails
when a variable is undefined. As a result, attempting to deploy the `_dns` project will
cause the deployment script to terminate with an error, preventing the entire DNS load
balancer configuration from being applied. This affects all services that rely on this
DNS configuration, not just the new Vue service.
Did we get this right? 👍 / 👎 to inform future reviews.
maxkosty
left a comment
There was a problem hiding this comment.
Description
Adding Vue domain to load balancer config as part of Vue Demo Refresh (#994 )