Do not ignore hgatp writes with a reserved MODE encoding - #1915
Do not ignore hgatp writes with a reserved MODE encoding#1915Nadime Barhoumi (nadime15) wants to merge 1 commit into
Conversation
Per `norm:hgatp_mode_warl` such a write is not ignored like it is for `satp`, the fields are WARL, so VMID and PPN take the written values and MODE falls back to Bare (a legal value).
|
So this PR sets (The PR itself fixes a bug where VMID and PPN should be written no matter if the write to The question is whether we want a config option so the user can choose, for example to match Spike. The whole function already assumes Bare is always supported, even before this PR we return Bare on an illegal write. Or we could just switch to Spike's behavior. So there are 3 options, keep it as it is, switch to Spikes default behaviour or introduce a config option that allows BARE OR the prev. value in case of an illegal write. |
|
I suggest just following Spike for now and keeping the previous value. We can add options for other behavior later if needed. |
2 participants
Per
norm:hgatp_mode_warlsuch a write is not ignored like it is forsatp, the fields are WARL, so VMID and PPN take the written values and MODE falls back to Bare (a legal value in this case).