Expose AK_ifetch / AK_ttw at the concurrency interface - #1911
Open
Nickolai Zeldovich (zeldovich) wants to merge 1 commit into
Open
Expose AK_ifetch / AK_ttw at the concurrency interface#1911Nickolai Zeldovich (zeldovich) wants to merge 1 commit into
Nickolai Zeldovich (zeldovich) wants to merge 1 commit into
Conversation
The concurrency interface defines AK_ifetch and AK_ttw, but the current Sail model does not carry the information about the reason for a memory load through to the MemRead event. This change propagates the memory read type all the way through to the MemRead event. This makes it possible to implement memory models where instruction or page-table reads are treated differently (e.g., RISC-V's non-coherent icache). This patch is the result of a verification project on top of the Sail model using Claude Code, and the patch itself was also co-developed together with Claude Code.
Collaborator
|
I think this is handled in #1871, which is moving to a new version of this interface. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The concurrency interface defines AK_ifetch and AK_ttw, but the current Sail model does not carry the information about the reason for a memory load through to the MemRead event. This change propagates the memory read type all the way through to the MemRead event. This makes it possible to implement memory models where instruction or page-table reads are treated differently (e.g., RISC-V's non-coherent icache).
This patch is the result of a verification project on top of the Sail model using Claude Code, and the patch itself was also co-developed together with Claude Code.