Fix and test exact-locale and base-language fallback handling in TranslationMixin.trans and SearchFilter#1590
Open
MyPyDavid wants to merge 5 commits into2.4.5/releasefrom
Open
Fix and test exact-locale and base-language fallback handling in TranslationMixin.trans and SearchFilter#1590MyPyDavid wants to merge 5 commits into2.4.5/releasefrom
MyPyDavid wants to merge 5 commits into2.4.5/releasefrom
Conversation
Signed-off-by: David Wallace <david.wallace@tu-darmstadt.de>
Signed-off-by: David Wallace <david.wallace@tu-darmstadt.de>
Signed-off-by: David Wallace <david.wallace@tu-darmstadt.de>
…xin.trans Signed-off-by: David Wallace <david.wallace@tu-darmstadt.de>
MyPyDavid
changed the title
|
Coverage is 94.915% — 2.4.5/fix/translationmixin into 2.4.5/release. No base build found for |
Signed-off-by: David Wallace <david.wallace@tu-darmstadt.de>
MyPyDavid
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Possibly Related issue: #1589
Is the TranslationMixin now broken or not?!
PS It did not support the behaviour of the new tests so it was broken somehow..