Use short_title in compute_navigation#1586
Conversation
|
I though it would be easy to add a simple test for this but I think that the (Pdb) django.utils.translation.get_language()
'en-us'
(Pdb) rdmo.core.utils.get_languages()
[('en', 'English', 'lang1'), ('de', 'German', 'lang2')]and we try to compare Line 38 in e77e2ca (Pdb) section.short_title_lang1
'SectionShorty'
(Pdb) section.short_title
''🤯 ❓ |
Signed-off-by: David Wallace <david.wallace@tu-darmstadt.de>
Signed-off-by: David Wallace <david.wallace@tu-darmstadt.de>
|
Still the new tests (without the fix for TranslationMixin) did not fail in the CI somehow, maybe some leaky tests were setting the locale to |
|
If these tests in #1590 also pass then I give up. 🎤-drop |
Signed-off-by: David Wallace <david.wallace@tu-darmstadt.de>
MyPyDavid
left a comment
There was a problem hiding this comment.
Fixed and tested.
The two other changes to translations in the tests are unrelated but I don't want to force-push the branch right now so..
|
|
||
| # ARRANGE: clear the normal titles and set short titles | ||
| section.title_lang1 = "" | ||
| section.short_title_lang1 = 'SectionShorty' |
There was a problem hiding this comment.
this was the test that was simply broken somehow on my machine because I had en-us as the locale language
Shot titles where accidentally removed in RDMO 2.4.0. This restores there use in the sidebar of the interview. Draft for now since I don't know if we want to have an extra release for this.