test(upc-aws): add response status validation and diags#11443
test(upc-aws): add response status validation and diags#11443DariuszPorowski wants to merge 2 commits intomainfrom
Conversation
Signed-off-by: Dariusz Porowski <3431813+DariuszPorowski@users.noreply.github.com>
de3e393 to
23ee99f
Compare
There was a problem hiding this comment.
Pull request overview
Improves AWS functional tests’ failure diagnostics (for investigating flaky Test_AWS_ListResources in #10556) by validating HTTP response status codes and emitting response headers/body on mismatch.
Changes:
- Switch tests to
t.Context()and make log group name generation a test helper. - Add
requireResponseStatushelper to fail with detailed response diagnostics. - Use the new status helper in
Test_AWS_DeleteResourceandTest_AWS_ListResources.
You can also share your feedback on Copilot code review. Take the survey.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11443 +/- ##
=======================================
Coverage 51.22% 51.23%
=======================================
Files 699 699
Lines 44062 44062
=======================================
+ Hits 22572 22574 +2
+ Misses 19330 19329 -1
+ Partials 2160 2159 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/LGTM after above copilot suggestion to closing deleteResponse.Body on the success path is updated. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Dariusz Porowski <3431813+DariuszPorowski@users.noreply.github.com>
Radius functional test overviewClick here to see the test run details
Test Status⌛ Building Radius and pushing container images for functional tests... |
Description
This change will help diagnose #10556
Type of change
Contributor checklist
Please verify that the PR meets the following requirements, where applicable: