Skip to content

test(upc-aws): add response status validation and diags#11443

Open
DariuszPorowski wants to merge 2 commits intomainfrom
10556-diag
Open

test(upc-aws): add response status validation and diags#11443
DariuszPorowski wants to merge 2 commits intomainfrom
10556-diag

Conversation

@DariuszPorowski
Copy link
Member

Description

This change will help diagnose #10556

Type of change

  • This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

  • An overview of proposed schema changes is included in a linked GitHub issue.
    • Yes
    • Not applicable
  • A design document PR is created in the design-notes repository, if new APIs are being introduced.
    • Yes
    • Not applicable
  • The design document has been reviewed and approved by Radius maintainers/approvers.
    • Yes
    • Not applicable
  • A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
    • Yes
    • Not applicable
  • A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
    • Yes
    • Not applicable
  • A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.
    • Yes
    • Not applicable

@DariuszPorowski DariuszPorowski self-assigned this Mar 18, 2026
@DariuszPorowski DariuszPorowski requested review from a team as code owners March 18, 2026 17:00
@DariuszPorowski DariuszPorowski linked an issue Mar 18, 2026 that may be closed by this pull request
1 task
Copilot AI review requested due to automatic review settings March 18, 2026 17:00
Signed-off-by: Dariusz Porowski <3431813+DariuszPorowski@users.noreply.github.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Improves AWS functional tests’ failure diagnostics (for investigating flaky Test_AWS_ListResources in #10556) by validating HTTP response status codes and emitting response headers/body on mismatch.

Changes:

  • Switch tests to t.Context() and make log group name generation a test helper.
  • Add requireResponseStatus helper to fail with detailed response diagnostics.
  • Use the new status helper in Test_AWS_DeleteResource and Test_AWS_ListResources.

You can also share your feedback on Copilot code review. Take the survey.

@github-actions
Copy link

github-actions bot commented Mar 18, 2026

Unit Tests

    2 files  ±0    415 suites  ±0   6m 46s ⏱️ -8s
4 881 tests ±0  4 879 ✅ ±0  2 💤 ±0  0 ❌ ±0 
5 783 runs  ±0  5 781 ✅ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 5d4cd1e. ± Comparison against base commit 0a26e31.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Mar 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.23%. Comparing base (0a26e31) to head (5d4cd1e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11443   +/-   ##
=======================================
  Coverage   51.22%   51.23%           
=======================================
  Files         699      699           
  Lines       44062    44062           
=======================================
+ Hits        22572    22574    +2     
+ Misses      19330    19329    -1     
+ Partials     2160     2159    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lakshmimsft
Copy link
Contributor

/LGTM after above copilot suggestion to closing deleteResponse.Body on the success path is updated.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Dariusz Porowski <3431813+DariuszPorowski@users.noreply.github.com>
@radius-functional-tests
Copy link

radius-functional-tests bot commented Mar 18, 2026

Radius functional test overview

🔍 Go to test action run

Click here to see the test run details
Name Value
Repository radius-project/radius
Commit ref 5d4cd1e
Unique ID func039182b1fe
Image tag pr-func039182b1fe
  • gotestsum 1.13.0
  • KinD: v0.29.0
  • Dapr: 1.14.4
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func039182b1fe
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func039182b1fe
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func039182b1fe
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func039182b1fe
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func039182b1fe
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
❌ ucp-cloud functional test failed. Please check the logs for more details
❌ corerp-cloud functional test cancelled. Please check the logs for more details
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
❌ ucp-cloud functional test failed. Please check the logs for more details
❌ corerp-cloud functional test cancelled. Please check the logs for more details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flaky test: Test_AWS_ListResources returns 400 intermittently

3 participants