test(upc-aws): add response status validation and diags

Signed-off-by: Dariusz Porowski <3431813+DariuszPorowski@users.noreply.github.com>

Author: DariuszPorowski

test/functional-portable/ucp/cloud/aws_test.go

@@ -23,6 +23,7 @@ import (
 	"fmt"
 	"io"
 	"net/http"
+	"sort"
 	"strings"
 	"testing"
 	"time"
@@ -45,10 +46,10 @@ var (
 )
 
 func Test_AWS_DeleteResource(t *testing.T) {
-	ctx := context.Background()
+	ctx := t.Context()
 
 	myTest := test.NewUCPTest(t, "Test_AWS_DeleteResource", func(t *testing.T, url string, roundTripper http.RoundTripper) {
-		logGroupName := generateLogGroupName()
+		logGroupName := generateLogGroupName(t)
 		setupTestAWSResource(t, ctx, logGroupName)
 		resourceID, err := validation.GetResourceIdentifier(ctx, logGroupResourceType, logGroupName)
 		require.NoError(t, err)
@@ -71,7 +72,7 @@ func Test_AWS_DeleteResource(t *testing.T) {
 		require.NoError(t, err)
 		deleteResponse, err := roundTripper.RoundTrip(deleteRequest)
 		require.NoError(t, err)
-		require.Equal(t, http.StatusAccepted, deleteResponse.StatusCode)
+		requireResponseStatus(t, deleteResponse, http.StatusAccepted)
 
 		// Get the operation status url from the Azure-Asyncoperation header
 		deleteResponseCompletionUrl := deleteResponse.Header["Azure-Asyncoperation"][0]
@@ -106,10 +107,10 @@ func Test_AWS_DeleteResource(t *testing.T) {
 }
 
 func Test_AWS_ListResources(t *testing.T) {
-	ctx := context.Background()
+	ctx := t.Context()
 
 	myTest := test.NewUCPTest(t, "Test_AWS_ListResources", func(t *testing.T, url string, roundTripper http.RoundTripper) {
-		var logGroupName = generateLogGroupName()
+		var logGroupName = generateLogGroupName(t)
 		setupTestAWSResource(t, ctx, logGroupName)
 		resourceID, err := validation.GetResourceIdentifier(ctx, logGroupResourceType, logGroupName)
 		require.NoError(t, err)
@@ -126,7 +127,7 @@ func Test_AWS_ListResources(t *testing.T) {
 		listResponse, err := roundTripper.RoundTrip(listRequest)
 		require.NoError(t, err)
 
-		require.Equal(t, http.StatusOK, listResponse.StatusCode)
+		requireResponseStatus(t, listResponse, http.StatusOK)
 
 		defer listResponse.Body.Close()
 		payload, err := io.ReadAll(listResponse.Body)
@@ -197,6 +198,41 @@ func waitForSuccess(t *testing.T, ctx context.Context, awsClient aws.AWSCloudCon
 	require.NoError(t, err)
 }
 
-func generateLogGroupName() string {
+func generateLogGroupName(t *testing.T) string {
+	t.Helper()
 	return "ucpfunctionaltest-" + uuid.NewString()
 }
+
+func requireResponseStatus(t *testing.T, response *http.Response, expectedStatus int) {
+	t.Helper()
+	require.NotNil(t, response)
+
+	if response.StatusCode == expectedStatus {
+		return
+	}
+
+	body, err := io.ReadAll(response.Body)
+	require.NoError(t, err)
+	require.NoError(t, response.Body.Close())
+
+	response.Body = io.NopCloser(bytes.NewReader(body))
+
+	headerKeys := make([]string, 0, len(response.Header))
+	for key := range response.Header {
+		headerKeys = append(headerKeys, key)
+	}
+	sort.Strings(headerKeys)
+
+	headers := make([]string, 0, len(headerKeys))
+	for _, key := range headerKeys {
+		headers = append(headers, fmt.Sprintf("%s=%s", key, strings.Join(response.Header.Values(key), ",")))
+	}
+
+	require.Failf(t, "unexpected response status",
+		"expected status %d, got %d\nheaders: %s\nbody: %s",
+		expectedStatus,
+		response.StatusCode,
+		strings.Join(headers, "; "),
+		string(body),
+	)
+}