Skip to content

add EL10 basic support - align EL10 PGSQL 16 default package version#1650

Merged
SugatD merged 6 commits into
puppetlabs:mainfrom
ikonia:main
Jun 24, 2026
Merged

add EL10 basic support - align EL10 PGSQL 16 default package version#1650
SugatD merged 6 commits into
puppetlabs:mainfrom
ikonia:main

Conversation

@ikonia

@ikonia ikonia commented Oct 31, 2025

Copy link
Copy Markdown
Contributor

Summary

single commit adding version alignment to EL10 default postgresql 16 package versions

Additional Context

Add any additional context about the problem here.

Continuation of existing pattern to support OS version -> default PGSQL packages

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

  • 🟢 Spec tests.
  • [ X] 🟢 Acceptance tests.
  • [ x] Manually verified. (For example puppet apply)
  • puppet-lint

@CLAassistant

CLAassistant commented Oct 31, 2025

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@bastelfreak

Copy link
Copy Markdown
Collaborator

please also add EL10 to metadata.json

@ikonia

ikonia commented Nov 1, 2025

Copy link
Copy Markdown
Contributor Author

sorry metadata.json - had it locally hadn't committed

@ikonia

ikonia commented Nov 2, 2025

Copy link
Copy Markdown
Contributor Author

the CLA has been signed FYI: not sure why the job is not picking it up

@ikonia

ikonia commented Dec 6, 2025

Copy link
Copy Markdown
Contributor Author

I"ve once again verified I've signed CLA Version: 2021-08-31 and that the email used is the one used by my github account, the rechek function takes me to a signed Version: 2021-08-31 page, I'm unsure why this check is failing

@evgeni

evgeni commented Jan 7, 2026

Copy link
Copy Markdown
Contributor

@ikonia some commits are by Matt Darcy <mattd@projecthugo.co.uk> who has not signed the CLA

@ikonia

ikonia commented May 27, 2026

Copy link
Copy Markdown
Contributor Author

@SugatD if you are prepping for a release (I see you merged in other changes recently) could you please look at this, it's essential for EL10 support and a very minor and basic change

@ekohl

ekohl commented May 27, 2026

Copy link
Copy Markdown
Collaborator

@ikonia could you squash your commits?

@SugatD

SugatD commented May 27, 2026

Copy link
Copy Markdown
Contributor

Test PR created to run CI against these changes: #1672

add EL10 support for active distros
@ikonia

ikonia commented May 27, 2026

Copy link
Copy Markdown
Contributor Author

squashed with some helpful hand holding

@SugatD

SugatD commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

The acceptance test is failing for rhel-10 #1672. Other EL-10 platforms are not yet present, so I request you to keep only the platforms which are present in the acceptance tests.

The only failing example on RedHat-10 is spec/acceptance/server_instance_spec.rb ("installs postgres instance test1"); the other 60 examples pass. The Puppet apply fails with:

Error: Could not update: Execution of '/usr/bin/dnf module enable -d 0 -e 1 -y postgresql:16' returned 1:
Error: Problems in request:
missing groups or modules: postgresql:16
Error: /Stage[main]/Postgresql::Dnfmodule/Package[postgresql dnf module]/ensure:
change from 'purged' to '16' failed ...

(everything after that is Skipping because of failed dependencies, so the apply exits 6).

Why: the test hard-codes the DNF-module path (manage_dnf_module => true, version => '16'), which runs dnf module enable postgresql:16. RHEL 10 dropped DNF modularity entirely — there are no AppStream
module streams anymore, and PostgreSQL 16 ships as a plain non-modular package. So dnf module enable postgresql:16 can never succeed on EL10; the module-stream approach is only valid on EL8/EL9.

The test guard is the actual problem — it was written to exclude only RHEL 7, so it now also runs on RHEL 10:

# spec/acceptance/server_instance_spec.rb:6
if: os[:family] == 'redhat' && !os[:release].start_with?('7')

Suggested fix: restrict the guard to the releases that support module streams (EL8/EL9):

if: os[:family] == 'redhat' && os[:release].to_i.between?(8, 9)


Please add a fix and run acceptance test.

@SugatD

SugatD commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

The acceptance test is failing for rhel-10 #1672. Other EL-10 platforms are not yet present, so I request you to keep only the platforms which are present in the acceptance tests.

Updates on previous comment: You can keep all the EL-10 platforms, no need to remove them.

@ikonia

ikonia commented Jun 8, 2026

Copy link
Copy Markdown
Contributor Author

@SugatD I've put in what I think is an acceptable update to the test spec, and I've also put a condition in the DNF module (now that I understand the problem the test spec was failing on) to conditionally fail if anyone tries to use the def module parameter with EL10 as an minor enhancement to adding support for EL10

@jst-cyr jst-cyr linked an issue Jun 23, 2026 that may be closed by this pull request
@SugatD

SugatD commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

@ikonia All the test are passing as per #1672, with the latest changes of this branch and it LGTM. Please rebase the branch once and will merge it at the earliest.

@ikonia

ikonia commented Jun 24, 2026

Copy link
Copy Markdown
Contributor Author

rebased

@SugatD SugatD merged commit 30b4f59 into puppetlabs:main Jun 24, 2026
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Default version for RHEL-10 missing

6 participants