add EL10 basic support - align EL10 PGSQL 16 default package version#1650
Conversation
|
please also add EL10 to metadata.json |
|
sorry metadata.json - had it locally hadn't committed |
|
the CLA has been signed FYI: not sure why the job is not picking it up |
|
I"ve once again verified I've signed CLA Version: 2021-08-31 and that the email used is the one used by my github account, the rechek function takes me to a signed Version: 2021-08-31 page, I'm unsure why this check is failing |
|
@ikonia some commits are by |
c1c4126 to
1c1b568
Compare
|
@SugatD if you are prepping for a release (I see you merged in other changes recently) could you please look at this, it's essential for EL10 support and a very minor and basic change |
|
@ikonia could you squash your commits? |
|
Test PR created to run CI against these changes: #1672 |
add EL10 support for active distros
|
squashed with some helpful hand holding |
The acceptance test is failing for rhel-10 #1672. Other EL-10 platforms are not yet present, so I request you to keep only the platforms which are present in the acceptance tests.The only failing example on RedHat-10 is spec/acceptance/server_instance_spec.rb ("installs postgres instance test1"); the other 60 examples pass. The Puppet apply fails with: Error: Could not update: Execution of '/usr/bin/dnf module enable -d 0 -e 1 -y postgresql:16' returned 1: (everything after that is Skipping because of failed dependencies, so the apply exits 6). Why: the test hard-codes the DNF-module path (manage_dnf_module => true, version => '16'), which runs dnf module enable postgresql:16. RHEL 10 dropped DNF modularity entirely — there are no AppStream The test guard is the actual problem — it was written to exclude only RHEL 7, so it now also runs on RHEL 10: # spec/acceptance/server_instance_spec.rb:6 Suggested fix: restrict the guard to the releases that support module streams (EL8/EL9):
Please add a fix and run acceptance test. |
Updates on previous comment: You can keep all the EL-10 platforms, no need to remove them. |
|
@SugatD I've put in what I think is an acceptable update to the test spec, and I've also put a condition in the DNF module (now that I understand the problem the test spec was failing on) to conditionally fail if anyone tries to use the def module parameter with EL10 as an minor enhancement to adding support for EL10 |
|
rebased |
Summary
single commit adding version alignment to EL10 default postgresql 16 package versions
Additional Context
Add any additional context about the problem here.
Continuation of existing pattern to support OS version -> default PGSQL packages
Related Issues (if any)
Mention any related issues or pull requests.
Checklist
puppet apply)