feat(workbench): add Background Job and Workbench Job test coverage (closes #302)#336
Merged
Merged
Conversation
…loses #302) - Add two @workbench BDD scenarios for job execution in RStudio Pro - Background Job and Workbench Job (Launcher) scenarios follow four-layer architecture with Playwright-driven step definitions - Add configurable job_timeout to WorkbenchConfig (default 120s) via [workbench] job_timeout in vip.toml - Add RStudio job pane selectors to RStudioSession page object - Add selftests for job_timeout config field Implements the plan from #316 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
posit-vip-triage
Bot
requested review from
bdeitte,
ian-flores and
statik
as code owners
Co-authored-by: ian-flores <18703558+ian-flores@users.noreply.github.com>
ian-flores
approved these changes
Jun 2, 2026
|
ian-flores
added a commit
that referenced
this pull request
Jun 11, 2026
ian-flores
added a commit
that referenced
this pull request
Jun 11, 2026
ian-flores
added a commit
that referenced
this pull request
Jun 11, 2026
ian-flores
added a commit
that referenced
this pull request
Jun 11, 2026
ian-flores
added a commit
that referenced
this pull request
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #302
Implements the plan from #316
Summary
Adds BDD test coverage for Workbench Background Jobs and Workbench Jobs (Launcher jobs) in RStudio Pro sessions — the gap identified in issue #302.
What changed
src/vip_tests/workbench/test_jobs.feature— two new@workbenchscenarios:src/vip_tests/workbench/test_jobs.py— Playwright step definitions following the four-layer architecture; defensivepytest.skipguards when either Jobs UI is absent in the deploymentsrc/vip_tests/workbench/pages/rstudio_session.py— job-related selectors for Background Jobs and Workbench Jobs panes added toRStudioSessionsrc/vip/config.py—job_timeoutfield added toWorkbenchConfig(default 120 s); configurable via[workbench] job_timeoutin vip.toml so operators can adapt to slow clusters without code changesselftests/test_config.py— three tests coveringjob_timeoutdefault, explicit value, and from-dict round-tripConfig option
Demo
See
validation_docs/demo-bot-implement-issue-302.mdfor the full demo.New config tests