docs: plan for #302 — workbench jobs coverage#316
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
posit-vip-triage
Bot
requested review from
bdeitte,
ian-flores and
statik
as code owners
ian-flores
reviewed
May 29, 2026
|
|
||
| **UNCONFIRMED**: Does the Background Jobs scenario require different Playwright selectors than Workbench Jobs, or can we reuse the same page object pattern? This depends on RStudio Pro's UI structure — will be resolved during implementation by inspecting the DOM. | ||
|
|
||
| **UNCONFIRMED**: Should job submission timeout be configurable, or hardcoded (e.g. 60s)? Short jobs should complete quickly, but network latency or cluster load could vary. Propose starting with a 60s hardcoded timeout and making it configurable only if customers report flakiness. |
Contributor
There was a problem hiding this comment.
Updated the plan — the timeout question is now resolved as configurable (commit docs: mark job timeout as configurable).
Co-authored-by: ian-flores <18703558+ian-flores@users.noreply.github.com>
ian-flores
approved these changes
Jun 1, 2026
|
posit-vip-triage Bot
added a commit
that referenced
this pull request
Jun 1, 2026
…loses #302) - Add two @workbench BDD scenarios for job execution in RStudio Pro - Background Job and Workbench Job (Launcher) scenarios follow four-layer architecture with Playwright-driven step definitions - Add configurable job_timeout to WorkbenchConfig (default 120s) via [workbench] job_timeout in vip.toml - Add RStudio job pane selectors to RStudioSession page object - Add selftests for job_timeout config field Implements the plan from #316 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
|
Pull request created: #336
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #302
This plan proposes adding BDD test coverage for Workbench Jobs (run on separate Kubernetes pods via Launcher) and Background Jobs (run in the same session). The plan includes:
test_jobs.featurefile with two scenariosThe plan addresses open questions about UI selectors, timeout configuration, and script writing approach. Review the plan file for full details on architecture, components, and verification steps.