fix(StatsGl): update stats-gl to ^4.2.3 and fix hidden panel - #2754
Open
ovaar wants to merge 1 commit into
Open
Conversation
Bump stats-gl 2.2.8 -> 4.2.3. In v4 the panel's positioning
(position: fixed; top/left; z-index) lives on the container's inline
style attribute rather than on the child canvases. The unconditional
removeAttribute('style') stripped that positioning, dropping the panel
to position: static at the bottom of the page where it was invisible.
Remove the duplicate unconditional strip; the clearStatsGlStyle-gated
call above it already covers the opt-in case.
|
@ovaar is attempting to deploy a commit to the Poimandres Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump stats-gl 2.2.8 -> 4.2.3.
In v4 the panel's positioning (position: fixed; top/left; z-index) lives on the container's inline style attribute rather than on the child canvases. The unconditional removeAttribute('style') stripped that positioning, dropping the panel to position: static at the bottom of the page where it was invisible.
Remove the duplicate unconditional strip; the clearStatsGlStyle-gated call above it already covers the opt-in case.