Skip to content

i18n(ja): fix 国立データベース監査ログ → データベース監査ログ#23057

Open
yahonda wants to merge 6 commits into
pingcap:i18n-ja-release-8.5from
yahonda:fix/national-database-audit-log
Open

i18n(ja): fix 国立データベース監査ログ → データベース監査ログ#23057
yahonda wants to merge 6 commits into
pingcap:i18n-ja-release-8.5from
yahonda:fix/national-database-audit-log

Conversation

@yahonda

@yahonda yahonda commented Jun 15, 2026

Copy link
Copy Markdown
Member

What is changed, added or deleted?

Fix erroneous "国立データベース監査ログ" to "データベース監査ログ" in 3 files:

  • tidb-cloud/features.md
  • tidb-cloud/security-concepts.md
  • tidb-cloud/tidb-cloud-roadmap.md

The "国立" prefix is a mistranslation. The English source is simply "Database audit logging" without any "national" or "native" qualifier.

Which TiDB version(s) do your changes apply to?

  • master (the latest development version)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

  • This PR is translated from: N/A (Japanese translation fix)
  • Other reference link(s): N/A

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Remove erroneous '国立' prefix (likely a mistranslation of 'Native' or artifact)
from Database Audit Logging heading in 3 files.
@ti-chi-bot

ti-chi-bot Bot commented Jun 15, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign tangenta for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 15, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request corrects the Japanese translation of "Database Audit Log" from "国立データベース監査ログ" to "データベース監査ログ" across several TiDB Cloud documentation files. The reviewer recommended further improvements to the features table in tidb-cloud/features.md to resolve translation inconsistencies (such as mixing "storage" and "ストレージ") and to correct awkward phrasing regarding change feeds.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread tidb-cloud/features.md Outdated
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@qiancai qiancai added translation/no-need No need to translate this PR. and removed missing-translation-status This PR does not have translation status info. labels Jun 16, 2026
@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 16, 2026
@ti-chi-bot

ti-chi-bot Bot commented Jun 16, 2026

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2026-06-16 03:14:46.455609955 +0000 UTC m=+1448187.525927335: ☑️ agreed by qiancai.

@qiancai

qiancai commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

hi @yahonda, would you please resolve the conflicts of this PR? Thanks.

image

@yahonda

yahonda commented Jun 16, 2026

Copy link
Copy Markdown
Member Author

The conflict has been addressed and rebased.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants