Skip to content

Use REP103 SI units convention#98

Closed
andermi wants to merge 47 commits intomainfrom
andermi/84-use-rep103-si-unitsconvention
Closed

Use REP103 SI units convention#98
andermi wants to merge 47 commits intomainfrom
andermi/84-use-rep103-si-unitsconvention

Conversation

@andermi
Copy link
Collaborator

@andermi andermi commented Oct 3, 2022 •
edited
Loading

Address #84

  • PolytropicPneumaticSpring
  • ElectroHydraulicPTO
  • XbowAHRS
  • PowerController
  • SpringController

requires osrf/mbari_wec_utils#34

andermi and others added 30 commits August 23, 2022 17:49
@andermi
trying another interp; using eff maps from matlab
0487aac 
Signed-off-by: Michael Anderson <anderson@mbari.org>
@andermi
replaced interpolator; fixed tests after new efficiency maps
af87b95 
Signed-off-by: Michael Anderson <anderson@mbari.org>
@andermi
remove JustInterp; put limits on interpolation
b94db06 
Signed-off-by: Michael Anderson <anderson@mbari.org>
@andermi
fix pump in minutes
9f775b4 
Signed-off-by: Michael Anderson <anderson@mbari.org>
@andermi
move splinter to own package
4e8371f 
Signed-off-by: Michael Anderson <anderson@mbari.org>
@andermi
remove splinter from ehpto dir
27e11b8 
Signed-off-by: Michael Anderson <anderson@mbari.org>
@andermi
fix linters
973d81c 
Signed-off-by: Michael Anderson <anderson@mbari.org>
@andermi
add license and copy splinter meta to package after clone
850bcb1 
Signed-off-by: Michael Anderson <anderson@mbari.org>
@quarkytale
Merge branch 'main' into andermi/ehpto_solver
074dd45 
Signed-off-by: Dharini Dutia <dharini@openrobotics.org>
@andermi
make ros wrapper for splinter to avoid Eigen issues
75b8b2e 
Signed-off-by: Michael Anderson <anderson@mbari.org>
@hamilton8415
Progress on integrating test involving test-machine datax
4c47018
@hamilton8415
Merge branch 'andermi/ehpto_solver' into hamilton8415/testmachinecompare
cf8d284 
Merging in andermi's splinter solver
@andermi
fix splinter-related issue in torque policy; add debugger option to l…
b1e4c48 
…aunch files

Signed-off-by: Michael Anderson <anderson@mbari.org>
@andermi
move splinter to buoy_msgs
e2c9af3 
Signed-off-by: Michael Anderson <anderson@mbari.org>
@andermi
debugged badalloc for splinter
8521e05 
Signed-off-by: Michael Anderson <anderson@mbari.org>
@andermi
fix splinter_ros issues; remove references to buoy_examples
91a2a69 
Signed-off-by: Michael Anderson <anderson@mbari.org>
@andermi
hack: remove buoy_examples from build-and-test workflow
98537cc 
Signed-off-by: Michael Anderson <anderson@mbari.org>
@hamilton8415
Adding experiment comparisons
4eceaee
@hamilton8415
Merge branch 'andermi/ehpto_solver' of github.com:osrf/buoy_sim into …
520cb5f 
…hamilton8415/testmachinecompare
@hamilton8415
Created test fixture code and worlds to allow data from pto experimen…
64ccf1e 
…ets on physical test bench to be compared to simulation results. At the moment ElectroHydrauclicPTO does not seem to be working correctly, not reporting sensible RPM, etc.w
@hamilton8415
Completed first version of test that compares ElectroHydraulicPTO res…
26bfb79 
…ults to test machine data. Issue with ElectroHydraulicPTO not creating all entities in the first iteration.
@hamilton8415
Changed hard-coded filename in pto_experiement_comparison.cpp to not …
f33caf1 
…start with "EXP_" so plots won't be triggered if CI tries to run this test
@hamilton8415
i
c7d3965
@hamilton8415
Merge branch 'main' of github.com:osrf/buoy_sim into hamilton8415/tes…
8efac71 
…tmachinecompare
@hamilton8415
Fixed CMakeLists.txt and added units to gnuplot plots
4094776
@hamilton8415
Limited test run length to input data length.
00d6452
@andermi
use splinter in pto_experiment_comparison; cleanup cmake; export inte…
c25875b 
…rface for ElectroHydraulicState

Signed-off-by: Michael Anderson <anderson@mbari.org>
@hamilton8415
Added fields to tests data
0da47d0
@andermi
Merge remote-tracking branch 'origin/hamilton8415/testmachinecompare'…
7a22daa 
… into hamilton8415/testmachinecompare

Signed-off-by: Michael Anderson <anderson@mbari.org>
@andermi
cleanup and fix symlink to test_inputdata
f913103 
Signed-off-by: Michael Anderson <anderson@mbari.org>
andermi and others added 17 commits September 27, 2022 18:58
@andermi
adding spring test-machine comparison
8686626 
Signed-off-by: Michael Anderson <anderson@mbari.org>
@hamilton8415
Committing to change branches
0d56fd2
@andermi
fix polytropic spring curves; minor tweaks
32c60af 
Signed-off-by: Michael Anderson <anderson@mbari.org>
@andermi
recompute volume instead of writing to file; init piston pos to first…
d4fcfc0 
… value from data

Signed-off-by: Michael Anderson <anderson@mbari.org>
@andermi
linters; for now, use separate data files for spring test
47a7892 
Signed-off-by: Michael Anderson <anderson@mbari.org>
@andermi
combining tests into one fixture
9cd9586 
Signed-off-by: Michael Anderson <anderson@mbari.org>
@hamilton8415
Adjusted files to pass linters and other tests.
b28ee78
@andermi
Merge branch 'hamilton8415/testmachinecompare' into andermi/test_mach…
66bbea6 
…ine_spring

Signed-off-by: Michael Anderson <anderson@mbari.org>
@andermi
spring test done but wont pass; tweaks
f1f7d87 
Signed-off-by: Michael Anderson <anderson@mbari.org>
@andermi
got testbench tests passing for spring and pto
9512140 
Signed-off-by: Michael Anderson <anderson@mbari.org>
@andermi
remove old test from cmake
85e56d2 
Signed-off-by: Michael Anderson <anderson@mbari.org>
@andermi
remove old files
6ae03e3 
Signed-off-by: Michael Anderson <anderson@mbari.org>
@andermi
linters
24d9380 
Signed-off-by: Michael Anderson <anderson@mbari.org>
@andermi @hamilton8415
Added enforcement of min/max winding current to match the actual cont…
5c2d553 
…roller. (#96)

Co-authored-by: Andrew Hamilton <hamilton@mbari.org>
@andermi
Merge branch 'main' into andermi/test_machine_spring
2aac3b1
@andermi
temporarily relax piston position test for bias/windcurr
29ad3e0 
Signed-off-by: Michael Anderson <anderson@mbari.org>
@andermi
SI units for spring
fe4fe34 
Signed-off-by: Michael Anderson <anderson@mbari.org>
@andermi andermi changed the base branch from main to andermi/test_machine_spring October 3, 2022 22:48
@andermi andermi linked an issue Oct 3, 2022 that may be closed by this pull request
Use REP103 SI Units/Convention #84
Closed
5 tasks
Base automatically changed from andermi/test_machine_spring to main October 5, 2022 18:13
@andermi andermi closed this Sep 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use REP103 SI Units/Convention

4 participants

@andermi @mabelzhang @quarkytale @hamilton8415