Skip to content

Feature/64264 comment fields for project attributes #21452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
toy wants to merge 60 commits into
base: dev
Choose a base branch
from
Draft

Feature/64264 comment fields for project attributes #21452

toy wants to merge 60 commits into from
+1,426 −394

Conversation

@toy
Copy link
Contributor

@toy toy commented Dec 15, 2025

Ticket

https://community.openproject.org/wp/64264

What are you trying to accomplish?

Allow to comment project attributes

Screenshots

What approach did you choose and why?

Merge checklist

  • Added/updated tests
  • Added/updated documentation in Lookbook (patterns, previews, etc)
  • Tested major browsers (Chrome, Firefox, Edge, ...)

@toy toy force-pushed the feature/64264-comment-fields-for-project-attributes branch 3 times, most recently from d6d9bcd to 7b1dd29 Compare December 19, 2025 21:35
@toy toy force-pushed the feature/64264-comment-fields-for-project-attributes branch 3 times, most recently from d96b04a to 3ca06f4 Compare January 8, 2026 16:11
@toy toy mentioned this pull request Jan 8, 2026
Merged
@toy toy force-pushed the feature/64264-comment-fields-for-project-attributes branch from 3ca06f4 to 53e8534 Compare January 8, 2026 20:50
@toy toy mentioned this pull request Jan 9, 2026
Merged
@toy toy force-pushed the feature/64264-comment-fields-for-project-attributes branch 2 times, most recently from 22dc532 to 8fc8b9f Compare January 15, 2026 17:47
@github-actions github-actions bot temporarily deployed to gh-6899875-pr-21452 January 15, 2026 18:22 Inactive
@toy toy force-pushed the feature/64264-comment-fields-for-project-attributes branch from 8fc8b9f to 406b2ff Compare January 19, 2026 19:44
@github-actions github-actions bot temporarily deployed to gh-6899875-pr-21452 January 19, 2026 19:44 Inactive
@toy toy force-pushed the feature/64264-comment-fields-for-project-attributes branch from 406b2ff to 8fc1727 Compare January 20, 2026 20:04
@github-actions github-actions bot requested a deployment to gh-6899875-pr-21452 January 20, 2026 20:05 Pending
@toy toy force-pushed the feature/64264-comment-fields-for-project-attributes branch from 8fc1727 to fc6b5c8 Compare January 26, 2026 20:40
@github-actions github-actions bot temporarily deployed to gh-6899875-pr-21452 January 26, 2026 20:40 Inactive
@toy toy force-pushed the feature/64264-comment-fields-for-project-attributes branch from fc6b5c8 to 26c4df2 Compare January 28, 2026 20:27
@github-actions github-actions bot temporarily deployed to gh-6899875-pr-21452 January 28, 2026 20:27 Inactive
@toy toy force-pushed the feature/64264-comment-fields-for-project-attributes branch from 26c4df2 to 0e1b24b Compare January 29, 2026 13:19
@github-actions github-actions bot temporarily deployed to gh-6899875-pr-21452 January 29, 2026 13:20 Inactive
@github-actions github-actions bot temporarily deployed to gh-6899875-pr-21452 January 29, 2026 21:20 Inactive
@toy toy force-pushed the feature/64264-comment-fields-for-project-attributes branch from ad81a62 to c7956ed Compare February 2, 2026 20:56
@github-actions github-actions bot temporarily deployed to gh-6899875-pr-21452 February 2, 2026 23:18 Inactive
toy added 28 commits February 3, 2026 21:50
@toy
use same logic for hiding deleted custom field activity as for comments
1160f4f 
Currently removing custom field will reveal its activity except for
project, for which current state of linking is used, which is deleted
alongside custom field itself
@toy
move admin_only check of custom field related activity to the query
309df27 
This should be more efficient and will ensure "The changes were
retracted" message shown when all changes are hidden
@toy
to_h not needed after index_with and index_value also accepts value i…
a31cb31 
…nstead of block
@toy
rename expected_allowed_params to expected_permitted
8b59b1b
@toy
more explicit expectation when params forbidden
38af650
@toy
add availability join for customizable journal
9618bd1
@toy
allow showing journal diff for deleted custom fields
e4935a2
@toy
delegate CustomField#can_have_comment? instead of defining
45edd8b
@toy
adapt changes from ac1f346 and 4ab26f5 to custom comment journaling
cf4e072
@toy
rename method in projects update contract to reduce confusion
4548978 
with_all_available_custom_fields_only =>
with_all_available_custom_fields, as it allows other changes too
@toy
add CustomField#comment_attribute_name
c70d995
@toy
allow custom comment attributes through project update contract
67bbb68
@toy
unify and mark with question boolean methods in update contract
f06a3ee
@toy
refactor checking if field can be diffed
9d11093
@toy
rename ShowComponent to SectionComponent for clarity
de0b6cf
@toy
transform keys to strings instead of converting to hash with indiffer…
fdb3552 
…ent access
@toy
field for custom comment
7a01509
@toy
extract DialogComponent for shared behaviour between Edit and Show di…
73812d8 
…alogs
@toy
action and permission for dialog to show value'n'comment
5d40f76
@toy
change custom_values_for_custom_field to accept custom field or id an…
726fae3 
…d as positional argument
@toy
permit custom comments for projects
fc0b5b2
@toy
inherit item component from show component allowing to render comment
818f465
@toy
use anchors in all regexps for register_journal_formatted_fields
c8ff519
@toy
move configuration for ability to have custom comments to acts_as_cus…
3c43b3b 
…tomizable
@toy
move adding custom_comments relation to acts_as_customizable and mark…
0bd3f6b 
… for autosave
@toy
allow to assign comments in a way similar to values
4694b37
@toy
include acts as customizable methods at start of call
79ea526
@toy
return changes to comments from custom_field_changes and changed_with…
1165f35 
…_custom_fields
@toy toy force-pushed the feature/64264-comment-fields-for-project-attributes branch from c7956ed to 1165f35 Compare February 3, 2026 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

pullpreview

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@toy @lindenthal