rename ProjectCustomFieldEditController to ProjectCustomFieldModalController

It is going to allow also to view comment for users with view, but no
edit permission

Author: toy

…/project-custom-field-edit.controller.ts …project-custom-field-modal.controller.tsfrontend/src/stimulus/controllers/dynamic/project-custom-field-edit.controller.ts renamed to frontend/src/stimulus/controllers/dynamic/project-custom-field-modal.controller.ts frontend/src/stimulus/controllers/dynamic/project-custom-field-edit.controller.ts renamed to frontend/src/stimulus/controllers/dynamic/project-custom-field-modal.controller.ts

@@ -31,7 +31,7 @@
 
 import { Controller } from '@hotwired/stimulus';
 
-export default class ProjectCustomFieldEditController extends Controller {
+export default class ProjectCustomFieldModalController extends Controller {
   static values = {
     url: { type: String },
   };

modules/overviews/app/components/overviews/project_custom_fields/item_component.rb

@@ -67,13 +67,13 @@ def editable_wrapper
           tag: :div,
           classes: "project-custom-field-clickable",
           data: {
-            controller: "project-custom-field-edit async-dialog",
-            "project-custom-field-edit-url-value": edit_project_custom_field_path(project_id: @project.id,
+            controller: "project-custom-field-modal async-dialog",
+            "project-custom-field-modal-url-value": edit_project_custom_field_path(project_id: @project.id,
                                                                                   id: @project_custom_field.id),
-            action: "click->project-custom-field-edit#openEditDialog " \
-                    "keydown.enter->project-custom-field-edit#openEditDialog " \
-                    "keydown.space->project-custom-field-edit#openEditDialog " \
-                    "project-custom-field-edit:open-dialog->async-dialog#handleOpenDialog"
+            action: "click->project-custom-field-modal#openEditDialog " \
+                    "keydown.enter->project-custom-field-modal#openEditDialog " \
+                    "keydown.space->project-custom-field-modal#openEditDialog " \
+                    "project-custom-field-modal:open-dialog->async-dialog#handleOpenDialog"
           },
           aria: {
             label: [
@@ -83,7 +83,7 @@ def editable_wrapper
           },
           role: "button",
           tabindex: 0,
-          test_selector: "project-custom-field-edit-button-#{@project_custom_field.id}"
+          test_selector: "project-custom-field-modal-button-#{@project_custom_field.id}"
         )
       end
 

spec/support/pages/projects/show.rb

@@ -93,7 +93,7 @@ def open_edit_dialog_for_custom_field(custom_field)
           # Once we create the project custom field inline editing, this can be reverted to a normal
           # capybara click method call.
           page.execute_script(
-            "document.querySelector('[data-test-selector=\"project-custom-field-edit-button-#{custom_field.id}\"]').click()"
+            "document.querySelector('[data-test-selector=\"project-custom-field-modal-button-#{custom_field.id}\"]').click()"
           )
         end