Skip to content

Replace unary_union with union_all #1270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
giswqs merged 3 commits into from
Nov 18, 2025
Merged

Replace unary_union with union_all #1270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4817454
Rename height param in deckgl
giswqs Nov 17, 2025
54682ca
Replace unary_union with union_all
giswqs Nov 18, 2025
10c3d34
Merge branch 'master' into union
giswqs Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions leafmap/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9082,9 +9082,9 @@ def filter_bounds(data, bbox, within=False, align=True, **kwargs: Any) -> Any:
bbox = gpd.read_file(bbox, **kwargs)

if within:
result = data[data.within(bbox.unary_union, align=align)]
result = data[data.within(bbox.union_all(), align=align)]
else:
result = data[data.intersects(bbox.unary_union, align=align)]
result = data[data.intersects(bbox.union_all(), align=align)]

return result

Expand Down Expand Up @@ -10827,7 +10827,7 @@ def get_3dep_dem(
if isinstance(geometry, gpd.GeoDataFrame):
if src_crs is None:
src_crs = geometry.crs
geometry = geometry.geometry.unary_union
geometry = geometry.geometry.union_all()

if src_crs is None:
src_crs = "EPSG:4326"
Expand Down Expand Up @@ -17087,9 +17087,9 @@ def get_nhd(
crs = f"EPSG:{geo_crs}"
geometry = construct_bbox(*geometry, buffer=buffer, crs=crs, return_gdf=False)
elif isinstance(geometry, gpd.GeoDataFrame):
geometry = geometry.unary_union
geometry = geometry.union_all()
elif isinstance(geometry, str):
geometry = gpd.read_file(geometry).unary_union
geometry = gpd.read_file(geometry).union_all()

water_data = WaterData(dataset)

Expand Down
4 changes: 2 additions & 2 deletions leafmap/stac.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2159,9 +2159,9 @@ def maxar_search(
crs="epsg:4326",
)
if within:
data = data[data.within(bbox.unary_union, align=align)]
data = data[data.within(bbox.union_all(), align=align)]
else:
data = data[data.intersects(bbox.unary_union, align=align)]
data = data[data.intersects(bbox.union_all(), align=align)]

date_field = "datetime"
new_field = f"{date_field}_temp"
Expand Down