Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the codebase to use the newer union_all() method instead of the deprecated unary_union property from geopandas. The PR also includes an unrelated fix in the deckgl module that corrects a parameter name passed to the parent class.
- Replaces all occurrences of
.unary_unionwith.union_all()across three files - Fixes incorrect parameter name
_heighttoheightin deckgl.Map initialization - Ensures compatibility with geopandas 1.0.0+ API
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| leafmap/stac.py | Updates two usages of unary_union to union_all() in the maxar_search function for spatial filtering |
| leafmap/deckgl.py | Changes parameter from _height to height when initializing the parent lonboard.Map class |
| leafmap/common.py | Updates four usages of unary_union to union_all() across filter_bounds, get_3dep_dem, and get_nhd functions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| super().__init__( | ||
| _height=height, | ||
| height=height, |
There was a problem hiding this comment.
This parameter name change from _height to height appears unrelated to the PR title 'Replace unary_union with union_all'. Consider separating unrelated changes into separate PRs for clearer version control history and easier code review. However, if this is intentional (e.g., fixing a bug found during the refactoring), it should be mentioned in the PR description.
|
🚀 Deployed on https://691cadc1322ad4d4875111f1--opengeos.netlify.app |
* Rename height param in deckgl * Replace unary_union with union_all
No description provided.