Skip to content

[FIX] session: always return a Promise#7721

Closed
LucasLefevre wants to merge 1 commit into19.0from
19.0-transport-promise-lul
Closed

[FIX] session: always return a Promise#7721
LucasLefevre wants to merge 1 commit into19.0from
19.0-transport-promise-lul

Conversation

@LucasLefevre
Copy link
Collaborator

If the implementation of transportService doesn't return a Promise when calling sendMessage, the session breaks.

With this commit, we ensure we always get a Promise which allows to safely call .then or .catch

Task: 0

Description:

description of this task, what is implemented and why it is implemented that way.

Task: TASK_ID

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@robodoo
Copy link
Collaborator

robodoo commented Jan 7, 2026

Pull request status dashboard

If the implementation of `transportService` doesn't
return a Promise when calling `sendMessage`, the session breaks.

With this commit, we ensure we always get a Promise which allows
to safely call `.then` or `.catch`

Task: 0
@LucasLefevre LucasLefevre force-pushed the 19.0-transport-promise-lul branch from 8fabace to e980848 Compare January 7, 2026 12:08
@VincentSchippefilt
Copy link
Collaborator

robodoo r+

@robodoo robodoo closed this in b5f5d6d Jan 7, 2026
@fw-bot fw-bot deleted the 19.0-transport-promise-lul branch January 14, 2026 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants