Skip to content

[FIX] session: always return a Promise#7726

Closed
fw-bot wants to merge 1 commit intomasterfrom
master-19.0-transport-promise-lul-488517-fw
Closed

[FIX] session: always return a Promise#7726
fw-bot wants to merge 1 commit intomasterfrom
master-19.0-transport-promise-lul-488517-fw

Conversation

@fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Jan 7, 2026

If the implementation of transportService doesn't return a Promise when calling sendMessage, the session breaks.

With this commit, we ensure we always get a Promise which allows to safely call .then or .catch

Task: 0

Description:

description of this task, what is implemented and why it is implemented that way.

Task: TASK_ID

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #7721

If the implementation of `transportService` doesn't
return a Promise when calling `sendMessage`, the session breaks.

With this commit, we ensure we always get a Promise which allows
to safely call `.then` or `.catch`

Task: 0
X-original-commit: b5f5d6d
@robodoo
Copy link
Collaborator

robodoo commented Jan 7, 2026

Pull request status dashboard

@fw-bot
Copy link
Collaborator Author

fw-bot commented Jan 7, 2026

@LucasLefevre @VincentSchippefilt this PR targets master and is the last of the forward-port chain containing:

To merge the full chain, use

@robodoo r+

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@VincentSchippefilt
Copy link
Collaborator

robodoo r+

robodoo pushed a commit that referenced this pull request Jan 7, 2026
If the implementation of `transportService` doesn't
return a Promise when calling `sendMessage`, the session breaks.

With this commit, we ensure we always get a Promise which allows
to safely call `.then` or `.catch`

closes #7726

Task: 0
X-original-commit: b5f5d6d
Signed-off-by: Vincent Schippefilt (vsc) <[email protected]>
@robodoo robodoo added the 19.2 label Jan 7, 2026
@robodoo robodoo closed this Jan 7, 2026
@fw-bot fw-bot deleted the master-19.0-transport-promise-lul-488517-fw branch January 14, 2026 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants