-
Notifications
You must be signed in to change notification settings - Fork 111
feat: add payload limits documentation and update API reference #1034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughAdds a new API reference page documenting payload size limits (512KB for trigger/bulk/broadcast events, attachments excluded) and registers it in the API reference navigation (meta.json). Provides error examples, per-item bulk validation notes, and attachment size guidance. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
✏️ Tip: You can disable this entire section by setting Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Deploy Preview for docs-novu ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
content/docs/api-reference/payload-limits.mdx (1)
7-7: Consider minor wording improvement.The phrase "an essential functionality" could be simplified to "an essential feature" or "essential for" for better readability.
✨ Suggested wording improvement
-Payload size limits are an essential functionality for ensuring optimal performance and reliability of the system. They safeguard system resources by preventing oversized payloads from impacting API performance and ensure efficient processing of event triggers. +Payload size limits are essential for ensuring optimal performance and reliability of the system. They safeguard system resources by preventing oversized payloads from impacting API performance and ensure efficient processing of event triggers.
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
content/docs/api-reference/meta.jsoncontent/docs/api-reference/payload-limits.mdx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Redirect rules - docs-novu
- GitHub Check: Header rules - docs-novu
- GitHub Check: Pages changed - docs-novu
🔇 Additional comments (3)
content/docs/api-reference/payload-limits.mdx (2)
80-80: Verify the attachment documentation link path.The link uses an absolute path format (
/platform/integrations/email#sending-attachments). Ensure this matches the documentation site's routing conventions and that the anchor#sending-attachmentsexists in the target page.The verification script above will help locate the email integration documentation. Please confirm the link format and anchor are correct for your documentation framework.
1-88: Documentation is accurate with all links verified.The payload-limits documentation is well-structured with accurate technical information:
- All referenced links exist: rate-limiting, trigger-event, bulk-trigger-event, broadcast-event-to-all, and the sending-attachments section in email/index.mdx
- The 20MB attachment limit is confirmed in existing documentation
- Mathematical accuracy verified: 512KB = 524,288 bytes
- Error example is realistic: 524,342 bytes is 54 bytes over the 512KB limit
The documentation is ready to be published. To ensure the error message formats match actual API responses exactly, this should be confirmed with the API team before final release.
content/docs/api-reference/meta.json (1)
8-8: Appropriate navigation placement.The "payload-limits" entry is correctly positioned in the "Getting Started" section alongside other foundational API concepts (rate-limiting, idempotency). The slug matches the filename convention.
* Fix few typos in the payload limit content * fix description
|
Team, Is this page live? |
This pull request adds comprehensive documentation for API payload limits, clarifying the size restrictions for event triggers and how they are enforced. It introduces a new "Payload Limits" page in the API reference, detailing the 512KB payload size limit, error messages, and attachment handling.
Documentation improvements:
payload-limits.mdxpage documenting the 512KB payload size limit for event triggers, including what counts towards the limit, error message formats, and separate attachment limits.meta.jsonto include the new "Payload Limits" page in the API reference navigation.Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.