Skip to content

Add BUILD_TOOLS option, enable C++17 for CLI targets #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ProjitB merged 2 commits into from
Nov 4, 2025
Merged

Add BUILD_TOOLS option, enable C++17 for CLI targets #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d91ceec
Add BUILD_TOOLS options, enable C++17 for CLI targets.
kring Oct 29, 2025
2ce7360
Export all symbols on Windows by specifying -DCMAKE_WINDOWS_EXPORT_AL…
kring Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ jobs:
-DBUILD_SHARED_LIBS=$BUILD_SHARED_LIBS \
-DBUILD_TESTING=ON \
-DCMAKE_INSTALL_PREFIX=${CONDA_PREFIX} \
-DCMAKE_WINDOWS_EXPORT_ALL_SYMBOLS=ON \
..


Expand Down
43 changes: 30 additions & 13 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,22 +78,39 @@ install(EXPORT spzTargets
DESTINATION "${CMAKE_INSTALL_LIBDIR}/cmake/spz"
)

# CLI Tools
add_executable(ply_to_spz cli_tools/src/ply_to_spz.cpp)
target_link_libraries(ply_to_spz PRIVATE spz)
target_include_directories(ply_to_spz PRIVATE ${CMAKE_CURRENT_SOURCE_DIR}/src)
# --- Command Line Tools Option ---
option(BUILD_TOOLS "Build command line tools" ON)

if(BUILD_TOOLS)
# CLI Tools
add_executable(ply_to_spz cli_tools/src/ply_to_spz.cpp)
target_link_libraries(ply_to_spz PRIVATE spz)
target_include_directories(ply_to_spz PRIVATE ${CMAKE_CURRENT_SOURCE_DIR}/src)
set_target_properties(ply_to_spz PROPERTIES
CXX_STANDARD 17
CXX_STANDARD_REQUIRED ON
)

add_executable(spz_to_ply cli_tools/src/spz_to_ply.cpp)
target_link_libraries(spz_to_ply PRIVATE spz)
target_include_directories(spz_to_ply PRIVATE ${CMAKE_CURRENT_SOURCE_DIR}/src)
add_executable(spz_to_ply cli_tools/src/spz_to_ply.cpp)
target_link_libraries(spz_to_ply PRIVATE spz)
target_include_directories(spz_to_ply PRIVATE ${CMAKE_CURRENT_SOURCE_DIR}/src)
set_target_properties(spz_to_ply PROPERTIES
CXX_STANDARD 17
CXX_STANDARD_REQUIRED ON
)

add_executable(spz_info cli_tools/src/spz_info.cpp)
target_link_libraries(spz_info PRIVATE spz)
target_include_directories(spz_info PRIVATE ${CMAKE_CURRENT_SOURCE_DIR}/src)
add_executable(spz_info cli_tools/src/spz_info.cpp)
target_link_libraries(spz_info PRIVATE spz)
target_include_directories(spz_info PRIVATE ${CMAKE_CURRENT_SOURCE_DIR}/src)
set_target_properties(spz_info PROPERTIES
CXX_STANDARD 17
CXX_STANDARD_REQUIRED ON
)

install(TARGETS ply_to_spz spz_to_ply spz_info
RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR}
)
install(TARGETS ply_to_spz spz_to_ply spz_info
RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR}
)
endif()

# --- Python Bindings Option ---
option(BUILD_PYTHON_BINDINGS "Build Python bindings using nanobind" OFF)
Expand Down