Add BUILD_TOOLS option, enable C++17 for CLI targets#63
Add BUILD_TOOLS option, enable C++17 for CLI targets#63ProjitB merged 2 commits intonianticlabs:mainfrom
Conversation
|
The reason the Windows build with The reason the Windows build with |
We do this for the Conda Forge package because policy there is to not statically link. I agree it would be good to clearly state the public API with decorated exports on both unix and MSVC. And fix the type initialization warnings. And add proper tests 😄 It's a bit frustrating to have merged the CI PR and then release it while it is ❌. This is why I asked if it was a stated goal of the project to have MSVC builds. |
|
Yeah agree those things would be great @hobu, but, of course, everyone has competing priorities they need to consider. Hopefully this PR is an incremental step in the right direction, anyway. We will definitely be using this library on Windows/MSVC in cesium-native, FWIW. Also macOS, Linux, Android, iOS, UWP, and Emscripten. The efforts of everyone who has worked on it are much appreciated! |
CXX_STANDARD=17property to each of three CLI targets. Otherwise, compilation fails (at least on Windows / VS2022) when the non-C++-17 targets attempt to include headers that require C++17.BUILD_TOOLSconditional. This can be turned off by those who only need the library.I implemented both of these changes while adding the v2.1.0 release to vcpkg, but it would be better to have them upstream (here) if they're acceptable to the maintainers.
CC @hobu because this overlaps a bit with your #51.