Address conversion and initialization warnings on MSVC#51
Open
hobu wants to merge 6 commits intonianticlabs:mainfrom
Open
Address conversion and initialization warnings on MSVC#51hobu wants to merge 6 commits intonianticlabs:mainfrom
hobu wants to merge 6 commits intonianticlabs:mainfrom
Conversation
Contributor
Author
|
This PR (and the v2.1.0 release) was failing due to the cli_utils not having C++17 enabled. Does the project intend to support windows/MSVC? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This one requires #49 to see the resulting output, but it addresses a number of warnings that recent MSVC complains about. Please review them carefully if you decide to merge them. It is possible these casts are incorrect, but there is no way for me to verify data integrity because there are no tests.
Can we please have some tests? 😄
Howard