Sorts favourite files first in list#302
Sorts favourite files first in list#302AndyScherzinger merged 1 commit intonextcloud:masterfrom ryanwr:master
Conversation
|
@tobiasKaminsky can you (also) have a look? Code looks good to me. To be discussed if (as implemented in this PR by @ryanwr) there should be 2 chained sortings or if the sorting for the favorites should be incorporated in the 3 existing sorting implementations. That way you don't have to do a second sorting which makes the sorting implementations more complex but would save us 1 complete/additinal loop especially when it comes to very large file listings. |
|
I doubt that there is a real performance loss as there are very very few favorites files I guess. |
|
Then I am fine doing it like this 👍 |
|
Test were successful - so merging to master. Thanks @ryanwr for your contribution! 🎉 This will be part of the next stable release 1.4.0 |
|
@ryanwr very cool contribution! :) Added you to the Nextcloud organization and Android team :) |
|
Thanks! Happy to help |
Shows files marked as favourites first, closes issue #107