Sidebar menu redesign

[mario]

I am aware of the ongoing discussion regarding the menu redesign, and I'm opening this issue to both get an understanding of the current state of things, as well as clarify the new features I need to implement so we can all see how it'd work together.

My suggestion:

• Remove All files and On device from the sidebar menu

• Add a footer on the page with a filter icon in the left corner which would open a filter page (and contain "All files" and "On device" (among others). Since filter is whole other issue, we'll discuss this elsewhere.

• The top menu items would be:

• Home (webdav root)

• Favorites

• Photos

• Activities

• Notifications

• Uploads

• Settings

• Participate

I will open an issue for both activities and notifications separately, but maybe @karlitschek or @MorrisJobke can clarify the Photos - would it simply open a "Photos" directory (should the item be removed then if the user removes the dir) or will it show all photos on your instance? (in that case, I assume search API will be useful here - just need to know which extensions to use for searching).

@nextcloud/designers - your input is more than appreciated.

Also involving @AndyScherzinger and @tobiasKaminsky

[jancborchardt]

Gooood stuff! :)

So I don’t think this is as radical as you describe it:

• »Home« will just be like the old »All files«. And I’d prefer if we call it »All files« just like we do in the web interface
• Activities, Notifications and Uploads should be one and the same view. The mistake to split them up was made in the desktop client and it’s sooo confusing to have so many views for the same thing: chronological info.
• »Shared« is an entry we need, which shows a flat list of all elements shared by you, to you, or by link. (Not separate like on the server, we need to keep stuff simple and quickly accessible here.
• Photos could be a simple filter on everything which only shows the photos, and defaults to the grid view.
• Settings and participate are already there and will stay like now. :)

[mario]

@jancborchardt hehe. So will "All files" revert to webdav root anyway (because if it is, it's not the same way as currently)? I'm all for having one view for activities, notifications and uploads - but I'd appreciate a mockup of how this should look before I actually start working on this.

Shared - do you have any knowledge about the server side of this? (API and stuff) Maybe @MorrisJobke can shed some light on this? :)

Thoughts on the filter positioning as I've described it?

[tobiasKaminsky]

@jancborchardt Activities, Notifications and Uploads should be one and the same view

We should rethink this as in the current uploads view you have options like "retry failed", "delete failed", "delete successful", "remove all".
This will conflict with activities/notifications.

[tobiasKaminsky]

Add a footer on the page with a filter icon

the footer of the navigation drawer/sidebar is currently used for displaying the quota (if available)

[mario]

@tobiasKaminsky I meant the main screen, not sidebar.

[tobiasKaminsky]

@mario Shared - do you have any knowledge about the server side of this? (API and stuff) Maybe @MorrisJobke can shed some light on this? :)

This is an overview issue which should only target the restructure of the navigation drawer. Any questions/ideas regarding the "content" like "Shared" or "Photos" should be taken into a new issue which is then linked to this one

[tobiasKaminsky]

@tobiasKaminsky I meant the main screen, not sidebar. [Filtering position]

I would not take away space to add a footer. Instead I would put it in the overflow menu (three dots in the upper right corner) as it is an option related to the file list

[mario]

@tobiasKaminsky we can definitely discuss this - I think the menu is becoming overwhelming as-is anyway, and you need somewhere to show how is the list being filtered (and footer is a good place to put it).

[MorrisJobke]

Photos could be a simple filter on everything which only shows the photos, and defaults to the grid view.

Correct. 👍

Shared - do you have any knowledge about the server side of this? (API and stuff) Maybe @MorrisJobke can shed some light on this? :)

We have an OCS API for all incoming/outgoing shares of an user: https://docs.nextcloud.com/server/12/developer_manual/core/ocs-share-api.html

We should rethink this as in the current uploads view you have options like "retry failed", "delete failed", "delete successful", "remove all".
This will conflict with activities/notifications.

Yes. I would also like to keep them separate. Uploads is really only relevant for this device and has very little to do with the other activities on the server.

[tobiasKaminsky]

Upload view should stay separate.
But maybe we can combine notification and activity view?

So we need extra issues for

• photo view
• share view

[MorrisJobke]

photo view

Photo view is basically what we already have: the grid view of photos.

[eppfel]

In #559 I propose to ditch notifications from any view inside the app.

I actually think, when we integrate the notifications in Android natively, is there still the need to show them in any view inside the App? Choosing to act on the notification should directly transfer to it's content: Incoming call: open spreed.me, Update available: open admin settings, etc.