Skip to content

Fix CI artifact conflicts, test lifecycle methods, and add UDT funding error tests #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 5 commits into
base: oneway_channel
Choose a base branch
from
Draft

Fix CI artifact conflicts, test lifecycle methods, and add UDT funding error tests #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ca88fec
Initial plan
Copilot Feb 9, 2026
88f7852
Fix CI artifact name conflicts and test method naming
Copilot Feb 9, 2026
87604c6
Document high max_fee_rate values in test framework
Copilot Feb 9, 2026
3059e41
Fix code formatting with black
Copilot Feb 9, 2026
e354c8e
Add fnn-cli test cases for UDT funding error handling (PR #1253)
Copilot Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/fiber.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -576,7 +576,7 @@ jobs:
if: failure()
uses: actions/upload-artifact@v4
with:
name: jfoa-fiber_test_send_payment_debug_mixed-reports-${{ runner.os }}
name: jfoa-fiber_test_trampoline_routing_one_way-reports-${{ runner.os }}
path: ./report

fiber_test_compatibility:
Expand Down Expand Up @@ -612,6 +612,6 @@ jobs:
if: failure()
uses: actions/upload-artifact@v4
with:
name: jfoa-fiber_test_send_payment_debug_mixed-reports-${{ runner.os }}
name: jfoa-fiber_test_compatibility-reports-${{ runner.os }}
path: ./report

8 changes: 8 additions & 0 deletions framework/basic_fiber.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,6 +442,8 @@ def send_invoice_payment(
"invoice": invoice["invoice_address"],
"allow_self_payment": True,
"max_parts": hex(12),
# Extremely high max_fee_rate to avoid test failures due to fees
# Production code should use reasonable values (default is 5 = 0.5%)
"max_fee_rate": hex(1000000000000000),
}
if "allow_atomic_mpp" in invoice_params:
Expand All @@ -457,6 +459,8 @@ def send_invoice_payment(
"invoice": invoice["invoice_address"],
"allow_self_payment": True,
"max_parts": hex(12),
# Extremely high max_fee_rate to avoid test failures due to fees
# Production code should use reasonable values (default is 5 = 0.5%)
"max_fee_rate": hex(1000000000000000),
}
if "allow_atomic_mpp" in invoice_params:
Expand All @@ -476,6 +480,8 @@ def send_payment(self, fiber1, fiber2, amount, wait=True, udt=None, try_count=5)
"keysend": True,
"allow_self_payment": True,
"udt_type_script": udt,
# Extremely high max_fee_rate to avoid test failures due to fees
# Production code should use reasonable values (default is 5 = 0.5%)
"max_fee_rate": hex(1000000000000000),
# "final_tlc_expiry_delta": hex(120960000),
}
Expand All @@ -495,6 +501,8 @@ def send_payment(self, fiber1, fiber2, amount, wait=True, udt=None, try_count=5)
"keysend": True,
"allow_self_payment": True,
"udt_type_script": udt,
# Extremely high max_fee_rate to avoid test failures due to fees
# Production code should use reasonable values (default is 5 = 0.5%)
"max_fee_rate": hex(1000000000000000),
}
)
Expand Down
Empty file added test_cases/fiber/devnet/fnn-cli/__init__.py
View file
Open in desktop
Empty file.
Loading