Fix CI artifact conflicts, test lifecycle methods, and add UDT funding error tests#20
Draft
Copilot wants to merge 5 commits intooneway_channelfrom
Draft
Fix CI artifact conflicts, test lifecycle methods, and add UDT funding error tests#20Copilot wants to merge 5 commits intooneway_channelfrom
Copilot wants to merge 5 commits intooneway_channelfrom
Conversation
Merged
Co-authored-by: 15168316096 <[email protected]>
Co-authored-by: 15168316096 <[email protected]>
Co-authored-by: 15168316096 <[email protected]>
Copilot
AI
changed the title
[WIP] Update to address feedback on one-way channel PR
Fix CI artifact conflicts and test lifecycle methods in PR #17
Feb 9, 2026
Collaborator
|
@copilot 帮我回归一下这个pr,先弄清楚这个pr的修改的目的,nervosnetwork/fiber#1253 |
Agent-Logs-Url: https://github.com/gpBlockchain/fiber-py-integration-test/sessions/8dd56d3e-1890-4ffd-be98-df208a8e699e Co-authored-by: 15168316096 <[email protected]>
Contributor
Author
已完成测试用例补充(commit e354c8e) 理解的PR目的fiber PR #1253 修复了UDT通道在UDT cells未被索引时卡在negotiating状态的问题: 修复内容:
已添加的测试用例在 test_udt_funding_errors.py - 主要回归测试:
test_funding_error_classification.py - 错误处理测试:
所有测试用例已通过语法检查和代码格式化。 |
Copilot
AI
changed the title
Fix CI artifact conflicts and test lifecycle methods in PR #17
Fix CI artifact conflicts, test lifecycle methods, and add UDT funding error tests
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code review of PR #17 identified three issues: duplicate CI artifact names causing upload conflicts, incorrect pytest lifecycle method naming, and undocumented test framework behavior. Additionally, comprehensive test cases were added for UDT funding error handling based on fiber PR #1253.
Changes
CI Workflow (.github/workflows/fiber.yml)
fiber_test_trampoline_routing_one_wayandfiber_test_compatibilityjobsTest Lifecycle Methods
setUp()tosetup_method(self, method)in:test_cases/fiber/devnet/send_payment/params/test_fee.pytest_cases/fiber/devnet/trampoline_routing/test_fee_rate.pytest_cases/fiber/devnet/trampoline_routing/test_boundary_values.pySharedFiberTestsubclassesDocumentation (framework/basic_fiber.py)
max_fee_ratevalues (1000000000000000)Code Formatting
test_settle_invoice_edge_cases.pyNew Test Cases (test_cases/fiber/devnet/fnn-cli/)
test_udt_funding_errors.py: Tests for insufficient cells, retry mechanisms, and stuck channel preventiontest_funding_error_classification.py: Tests for error classification (temporary vs non-temporary), backoff mechanisms, and edge casesSecurity
No vulnerabilities detected by CodeQL scan.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.