Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/renderers/WebGLRenderer.js
Original file line number Diff line number Diff line change
Expand Up @@ -1097,6 +1097,7 @@ class WebGLRenderer {
properties.dispose();
environments.dispose();
objects.dispose();
geometries.dispose();
bindingStates.dispose();
uniformsGroups.dispose();
programCache.dispose();
Expand Down
30 changes: 26 additions & 4 deletions src/renderers/webgl/WebGLGeometries.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,15 @@ function WebGLGeometries( gl, attributes, info, bindingStates ) {
const geometries = {};
const wireframeAttributes = new WeakMap();

const registry = new FinalizationRegistry( ( id ) => delete geometries[ id ] );

function onGeometryDispose( event ) {

const geometry = event.target;
destroyGeometry( event.target );

}

function destroyGeometry( geometry ) {

if ( geometry.index !== null ) {

Expand All @@ -24,6 +30,7 @@ function WebGLGeometries( gl, attributes, info, bindingStates ) {
geometry.removeEventListener( 'dispose', onGeometryDispose );

delete geometries[ geometry.id ];
registry.unregister( geometry );

const attribute = wireframeAttributes.get( geometry );

Expand All @@ -50,11 +57,12 @@ function WebGLGeometries( gl, attributes, info, bindingStates ) {

function get( object, geometry ) {

if ( geometries[ geometry.id ] === true ) return geometry;
if ( geometries[ geometry.id ] !== undefined ) return geometry;

geometry.addEventListener( 'dispose', onGeometryDispose );

geometries[ geometry.id ] = true;
geometries[ geometry.id ] = new WeakRef( geometry );
registry.register( geometry, geometry.id, geometry );

info.memory.geometries ++;

Expand Down Expand Up @@ -171,12 +179,26 @@ function WebGLGeometries( gl, attributes, info, bindingStates ) {

}

function dispose() {

for ( const id in geometries ) {

const geometry = geometries[ id ].deref();

if ( geometry !== undefined ) destroyGeometry( geometry );

}

}

return {

get: get,
update: update,

getWireframeAttribute: getWireframeAttribute
getWireframeAttribute: getWireframeAttribute,

dispose: dispose

};

Expand Down