WebGLRenderer: Improve geometry disposal. - #34529
Merged
Merged
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PR: #20698
Description
We have recently introduced the usage of
WeakRefandFinalizationRegistryinWebGPURendererso we are able to remove existing dispose event listeners duringrenderer.dispose(). If we don't do that, it's not possible to fully free the resources of a renderer instance.The same issue exists in
WebGLRendererand this PR adapts the first part of the solution toWebGLGeometries. Interestingly, @gkjohnson suggested this exact fix years ago in #20698. At that time, the browser support forWeakRefandFinalizationRegistrywas still problematic but now it should be safe to use. In any event, the approach of #20698 was correct and we should have merged this PR a bit sooner.