Skip to content

Conversation

@eviljeff
Copy link
Member

@eviljeff eviljeff commented Jan 5, 2026

Fixes: mozilla/addons#15974

Description

Random fixes for broken/missing l10n in devhub.

Context

The description tooltip was broken because we had a conditional in the middle of the string (it needs to be repeated instead); highcharts dateFormat function wasn't localized, but we can use the javascript built-in instead.

Testing

Mostly just a matter of going to the correct page in a non-English locale

  • devhub upload details step for description
  • devhub edit details for description
  • devhub edit details for contribution url
  • devhub upload first step for theme upload blurb
  • stats dashboard, and choosing any of the views that have a data table

Checklist

  • Add #ISSUENUM at the top of your PR to an existing open issue in the mozilla/addons repository.
  • Successfully verified the change locally.
  • The change is covered by automated tests, or otherwise indicated why doing so is unnecessary/impossible.
  • Add before and after screenshots (Only for changes that impact the UI).
  • Add or update relevant docs reflecting the changes made.

@eviljeff eviljeff force-pushed the 15974-fix-l10n-in-devhub branch 2 times, most recently from 7abd1f5 to c82ae86 Compare January 6, 2026 10:31
@eviljeff eviljeff force-pushed the 15974-fix-l10n-in-devhub branch from c82ae86 to 777fafb Compare January 6, 2026 11:07
@eviljeff eviljeff marked this pull request as ready for review January 6, 2026 11:34
@eviljeff eviljeff requested a review from diox January 6, 2026 11:34
@eviljeff eviljeff merged commit 575fe8b into mozilla:master Jan 7, 2026
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Task]: Add-on Developers: Not localized text

2 participants