Skip to content

Commit 777fafb

Browse files
committed
fix broken/missing l10n in devhub
1 parent 2e82484 commit 777fafb

File tree

5 files changed

+27
-12
lines changed

5 files changed

+27
-12
lines changed

src/olympia/devhub/templates/devhub/addons/edit/additional_details.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ <h3>
4242
</th>
4343
<td>
4444
{% if editable %}
45-
<p>{{ _('Supported domains: %s'|format(', '.join(amo.VALID_CONTRIBUTION_DOMAINS))) }}</p>
45+
<p>{{ _('Supported domains: %(supported_domains)s', supported_domains=', '.join(amo.VALID_CONTRIBUTION_DOMAINS)) }}</p>
4646
<p>{{ main_form.contributions }}</p>
4747
{{ main_form.contributions.errors }}
4848
{% else %}

src/olympia/devhub/templates/devhub/addons/edit/describe.html

Lines changed: 18 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -126,12 +126,24 @@ <h3>
126126
<th>
127127
<label data-for="description">
128128
{{ _("Description") }}
129-
{{ tip(None,
130-
_("A longer explanation of features, functionality, and other relevant information. "
131-
"This field is only displayed on the add-on's product page. " +
132-
('Minimum length: 10 characters; ' if editable and main_form.description.field.min_length else '') +
133-
"Recommended length: 250 characters. "
134-
"If you need a longer description, make sure the first 250 characters contain the most important description points.")) }}
129+
{% if editable %}
130+
{{ tip(None,
131+
_("A longer explanation of features, functionality, and other relevant information. "
132+
"This field is only displayed on the add-on's product page. "
133+
"Minimum length: %(min_length)s characters; Recommended length: 250 characters. "
134+
"If you need a longer description, make sure the first 250 characters contain the most important description points.",
135+
min_length=main_form.description.field.min_length)
136+
)
137+
}}
138+
{% else %}
139+
{{ tip(None,
140+
_("A longer explanation of features, functionality, and other relevant information. "
141+
"This field is only displayed on the add-on's product page. "
142+
"Recommended length: 250 characters. "
143+
"If you need a longer description, make sure the first 250 characters contain the most important description points.")
144+
)
145+
}}
146+
{% endif %}
135147
</label>
136148
</th>
137149
<td>

src/olympia/devhub/templates/devhub/addons/submit/describe.html

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -105,10 +105,11 @@ <h3>{{ _('Describe Add-on') }}</h3>
105105
{{ describe_form.description.errors }}
106106
<div class="edit-addon-details">
107107
{{ _("A longer explanation of features, functionality, and other relevant information. "
108-
"This field is only displayed on the addon's product page. " +
109-
('Minimum length: 10 characters; ' if describe_form.description.field.min_length else '') +
110-
"Recommended length: 250 characters. "
111-
"If you need a longer description, make sure the first 250 characters contain the most important description points.") }}
108+
"This field is only displayed on the add-on's product page. "
109+
"Minimum length: %(min_length)s characters; Recommended length: 250 characters. "
110+
"If you need a longer description, make sure the first 250 characters contain the most important description points.",
111+
min_length=describe_form.description.field.min_length
112+
) }}
112113
<div class="char-count"
113114
data-for-startswith="{{ describe_form.description.auto_id }}_"
114115
data-minlength="{{ describe_form.description.field.min_length }}"></div>

src/olympia/devhub/templates/devhub/addons/submit/upload.html

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,8 +78,10 @@ <h3>{{ _('Upload Version') }}</h3>
7878
<p></p>
7979
<h3>{{ _('Create a Theme Version') }}</h3>
8080
<p>
81+
{% trans %}
8182
You can upload a finished theme using the upload option above,
8283
or you can build it yourself using this tool.
84+
{% endtrans %}
8385
</p>
8486
<div>
8587
<a class="button" id="wizardlink" href="{{ wizard_url }}">{{ _('Create a Theme') }}</a>

static/js/stats/table.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ $.fn.csvTable = function (cfg) {
103103
newBody += '<tr>';
104104
newBody +=
105105
'<th>' +
106-
Highcharts.dateFormat('%a, %b %e, %Y', Date.iso(d)) +
106+
Date.iso(d).toLocaleDateString($('html').attr('lang'), {"weekday": "short", "month": "short", "day": "numeric", "year": "numeric"}) +
107107
'</th>';
108108
_.each(fields, function (f) {
109109
newBody += '<td>';

0 commit comments

Comments
 (0)