docs: deprecate package in favor of niels-numbers/laravel-localizer - #955
Conversation
WalkthroughThe package is marked as abandoned in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
README.md (1)
9-21: ⚡ Quick winConsider clarifying the ongoing maintenance policy.
While the notice clearly states the package is "no longer actively maintained," you might want to explicitly mention whether critical security fixes will still be applied or if all maintenance has ceased entirely. This helps existing users assess risk.
For example, you could add a line like:
Note: This package will receive critical security fixes only until [date], after which no further updates will be provided.
Or if maintenance has completely stopped:
Note: This package is no longer receiving updates, including security fixes.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@README.md` around lines 9 - 21, Update the maintenance notice that begins "**This package is no longer actively maintained.**" in README.md to explicitly state the security/maintenance policy; add a single-line "Note:" immediately after that paragraph clarifying whether critical security fixes will be provided (and until what date) or that no further updates, including security fixes, will be made, and keep the wording concise and factual so users can quickly assess risk.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@README.md`:
- Around line 9-21: Update the maintenance notice that begins "**This package is
no longer actively maintained.**" in README.md to explicitly state the
security/maintenance policy; add a single-line "Note:" immediately after that
paragraph clarifying whether critical security fixes will be provided (and until
what date) or that no further updates, including security fixes, will be made,
and keep the wording concise and factual so users can quickly assess risk.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 33e4f5d6-0a04-48c5-ae9d-88ee5230630c
📒 Files selected for processing (2)
README.mdcomposer.json
|
Thanks @niels-numbers for your help all these years and good luck with the new package! PS: I really liked coderabbit's poem about this PR 😄 |
Heads-up @mcamara - pre-built per our LinkedIn DM today.
Two changes:
abandonedfield - Composer will show users a deprecation warning oncomposer install/composer updateThe
abandonedfield is the official Composer mechanism to redirect existing users at install time, so it complements the README note nicely.Wording, tone and placement are all open - feel free to adjust anything you'd like, or merge as-is. No rush from my end.
If you'd prefer a softer tone (e.g. "Active development has moved to..." instead of "no longer actively maintained"), happy to revise.
Thanks again for the goodwill - much appreciated.
Background: The successor package grew out of #921 and my appraoch to fix it in #934, where I started a v3.x rewrite of this package - but it became clear pretty quickly that the legacy constraints made it easier to start from scratch than to refactor in place.
Summary by CodeRabbit
Documentation
Chores