Skip to content

3.x adjust localizeurl - #934

Closed
niels-numbers wants to merge 21 commits into
3.xfrom
3.x-adjust-localizeurl
Closed

3.x adjust localizeurl#934
niels-numbers wants to merge 21 commits into
3.xfrom
3.x-adjust-localizeurl

Conversation

@niels-numbers

Copy link
Copy Markdown
Collaborator

I made changes to align getLocalizedURL with the new approach of receiving locale via middleware. This allowed me to significantly simplify the logic and remove a lot of what seemed unnecessary. However, I may have gone a bit too far—feedback is welcome!

@niels-numbers

Copy link
Copy Markdown
Collaborator Author

Closing this. The package is now abandoned with niels-numbers/laravel-localizer set as the Composer replacement (#955), and the intent of this PR - route locale flowing through middleware rather than being passed explicitly to a URL helper - is the default in the successor: the SetLocale middleware registers the active locale via Laravel's URL::defaults(), so route('about') resolves to the locale-correct variant automatically without a manual override. No further work needed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant