Conversation
…and elsewhere (e.g. Excel)
…splayed with deepdiff before committing changes to data
Closed
4 tasks
Collaborator
|
looking good... but just tried the demo and the final button to accept changes isn't there...? 
also. would be good to update the text where it currently says "change diff" to "addition in green, deletions in red" (with the word green colored green and red red |
Contributor
Author
|
The issue has now been fixed. It was a rendering issue in voila which caused the deepdiff custom widget to take up the full width, pushing the buttons off the screen. Setting a fixed with for the deepdiff widget solved the issue. |
Collaborator
|
great - could you add a couple of tests... don't need to be comprehensive but just to make sure it instantiates properly and basis functionality |
Contributor
Author
|
The tests have been added for functionality of the deepdiff and accept / reject buttons |
Added crud operations to edit_tsv
…sxdatagrid to edittsv
…ing added, updated integrationg of xlsxdatagrid with edittsv, EditTsvFileUpload added
…ation-from-xlsxdatagrid 366-import-edittsv-data-validation-from-xlsxdatagrid
Arshadwaqas115
changed the title
…o-deepdiffs-changes
…ffs-changes-within-edittsvwithdiff-to-get-the-full-row-including-the-fields-not-changed 382 add edited rows to deepdiffs changes within edittsvwithdiff to get the full row including the fields not changed
…to EditGrid instantiation for AutoUi.
…toui into 366-add-io-to-edit-grid
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature(s) added to edittsv:
When we click the upload button, a new view of the changes appears, prompting the user to either accept or decline the changes.
When the user clicks on the accept button, the changes are applied.
When the user clicks on the decline button, the changes are reverted.